Don't try to call setDefersLoading when the loader is null. This does a bit of cleanup so the che...

webkit/plugins/ppapi/ppb_url_loader_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_URL_LOADER_IMPL_H_
 #define WEBKIT_PLUGINS_PPAPI_PPB_URL_LOADER_IMPL_H_
 
 #include <deque>
 
 #include "base/memory/ref_counted.h"
@@ skipping 99 matching lines @@
   void UpdateStatus();
 
   // Returns true if the plugin has requested we record download or upload
   // progress. When false, we don't need to update the counters. We go out of
   // our way not to allow access to this information unless it's requested,
   // even when it would be easier just to return it and not check, so that
   // plugins don't depend on access without setting the flag.
   bool RecordDownloadProgress() const;
   bool RecordUploadProgress() const;
 
+  // Calls SetDefersLoading on the current load. This encapsulates the logic
+  // differences between document loads and regular ones.
+  void SetDefersLoading(bool defers_loading);
+
   void FinishLoading(int32_t done_status);
 
   // If true, then the plugin instance is a full-frame plugin and we're just
   // wrapping the main document's loader (i.e. loader_ is null).
   bool main_document_loader_;
 
   // Keep a copy of the request data. We specifically do this instead of
   // keeping a reference to the request resource, because the plugin might
   // change the request info resource out from under us.
   ::ppapi::PPB_URLRequestInfo_Data request_data_;
 
+  // The loader associated with this request. MAY BE NULL.
+  //
+  // This will be NULL if the load hasn't been opened yet, or if this is a main
+  // document loader (when registered as a mime type). Therefore, you should
+  // always NULL check this value before using it. In the case of a main
+  // document load, you would call the functions on the document to cancel the
+  // load, etc. since there is no loader.
   scoped_ptr<WebKit::WebURLLoader> loader_;
+
   scoped_refptr<PPB_URLResponseInfo_Impl> response_info_;
   scoped_refptr<TrackedCompletionCallback> pending_callback_;
   std::deque<char> buffer_;
   int64_t bytes_sent_;
   int64_t total_bytes_to_be_sent_;
   int64_t bytes_received_;
   int64_t total_bytes_to_be_received_;
   char* user_buffer_;
   size_t user_buffer_size_;
   int32_t done_status_;
   bool is_streaming_to_file_;
   bool is_asynchronous_load_suspended_;
 
   bool has_universal_access_;
 
   PP_URLLoaderTrusted_StatusCallback status_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(PPB_URLLoader_Impl);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPB_URL_LOADER_IMPL_H_