Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7307)

Unified Diff: chrome/chrome_browser.gypi

Issue 7919028: Revert 101581 - Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/hung_renderer_dialog.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
===================================================================
--- chrome/chrome_browser.gypi (revision 101584)
+++ chrome/chrome_browser.gypi (working copy)
@@ -2819,6 +2819,7 @@
'browser/ui/gtk/certificate_dialogs.cc',
'browser/ui/gtk/certificate_dialogs.h',
'browser/ui/gtk/certificate_viewer.cc',
+ 'browser/ui/gtk/certificate_viewer.h',
'browser/ui/gtk/chrome_gtk_frame.cc',
'browser/ui/gtk/chrome_gtk_frame.h',
'browser/ui/gtk/collected_cookies_gtk.cc',
@@ -4112,9 +4113,14 @@
'../ui/aura/aura.gyp:aura',
],
}],
- # Exclude WebUI certificate viewer if not POSIX or mac (these OS's have
- # native certificate viewers).
- ['os_posix == 0 or OS == "mac"', {
+ ['webui_dialogs == 1', {
+ 'defines': [
+ 'WEBUI_DIALOGS',
+ ],
+ }],
+ # Exclude WebUI certificate viewer if not POSIX, mac (these OS's have
+ # native certificate viewers) or WebUI dialogs are disabled.
+ ['webui_dialogs == 0 or os_posix == 0 or OS == "mac"', {
'sources/': [
['exclude', '^browser/ui/webui/certificate_viewer.cc'],
['exclude', '^browser/ui/webui/certificate_viewer.h'],
@@ -4122,6 +4128,23 @@
['exclude', '^browser/ui/webui/certificate_viewer_ui.h'],
],
}],
+ # Exclude other WebUI dialogs if WebUI dialogs are disabled.
+ ['webui_dialogs == 0', {
+ 'sources/': [
+ ['exclude', '^browser/ui/webui/hung_renderer_dialog.cc'],
+ ['exclude', '^browser/ui/webui/hung_renderer_dialog.h'],
+ ['exclude', '^browser/ui/webui/hung_renderer_dialog_ui.cc'],
+ ['exclude', '^browser/ui/webui/hung_renderer_dialog_ui.h'],
+ ],
+ }],
+ ['webui_dialogs == 1', {
+ 'sources/': [
+ ['exclude', '^browser/ui/gtk/certificate_viewer.cc'],
+ ['exclude', '^browser/ui/gtk/certificate_viewer.h'],
+ ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.cc'],
+ ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.h'],
+ ],
+ }],
['toolkit_uses_gtk == 1', {
'dependencies': [
'../build/linux/system.gyp:dbus',
@@ -4446,6 +4469,7 @@
['include', '^browser/ui/gtk/certificate_dialogs.cc'],
['include', '^browser/ui/gtk/certificate_dialogs.h'],
['include', '^browser/ui/gtk/certificate_viewer.cc'],
+ ['include', '^browser/ui/gtk/certificate_viewer.h'],
['include', '^browser/ui/gtk/chrome_gtk_frame.cc'],
['include', '^browser/ui/gtk/chrome_gtk_frame.h'],
['include', '^browser/ui/gtk/collected_cookies_gtk.cc'],
@@ -4758,6 +4782,15 @@
['exclude', '^browser/ui/panels/panel_mouse_watcher_gtk.cc'],
],
}],
+ # Exclude the GTK versions of dialogs if webui_dialogs are enabled.
+ ['webui_dialogs==1', {
+ 'sources/': [
+ ['exclude', '^browser/ui/gtk/certificate_viewer.cc'],
+ ['exclude', '^browser/ui/gtk/certificate_viewer.h'],
+ ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.cc'],
+ ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.cc.h'],
+ ],
+ }],
# Exclude these toolkit_views specific files again.
# (Required because of the '^browser/extensions/' include above)
['toolkit_views==0', {
« no previous file with comments | « chrome/browser/ui/webui/hung_renderer_dialog.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698