Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: build/common.gypi

Issue 7919028: Revert 101581 - Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_context_menu_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 13 matching lines...) Expand all
24 # Whether the Views toolkit can use its Pure form when available 24 # Whether the Views toolkit can use its Pure form when available
25 # or if it must only use GTK (the default at the moment). 25 # or if it must only use GTK (the default at the moment).
26 # This is an intermediate step until all of Views is 'Pure', 26 # This is an intermediate step until all of Views is 'Pure',
27 # at which point we plan to remove those switches. 27 # at which point we plan to remove those switches.
28 # This turns on the USE_ONLY_PURE_VIEWS macro. 28 # This turns on the USE_ONLY_PURE_VIEWS macro.
29 'use_only_pure_views%': 0, 29 'use_only_pure_views%': 0,
30 30
31 # Disable touch support by default. 31 # Disable touch support by default.
32 'touchui%': 0, 32 'touchui%': 0,
33 33
34 # Disable webui dialog replacements for native dialogs by default.
35 # TODO(flackr): Change this to a runtime flag triggered by
36 # --pure-views so that these dialogs can be easily tested.
37 'webui_dialogs%': 0,
38
34 # Whether the compositor is enabled on views. 39 # Whether the compositor is enabled on views.
35 'views_compositor%': 0, 40 'views_compositor%': 0,
36 41
37 # Whether or not we are building with the Aura window manager. 42 # Whether or not we are building with the Aura window manager.
38 'use_aura%': 0, 43 'use_aura%': 0,
39 }, 44 },
40 # Copy conditionally-set variables out one scope. 45 # Copy conditionally-set variables out one scope.
41 'chromeos%': '<(chromeos)', 46 'chromeos%': '<(chromeos)',
42 'use_only_pure_views%': '<(use_only_pure_views)', 47 'use_only_pure_views%': '<(use_only_pure_views)',
43 'touchui%': '<(touchui)', 48 'touchui%': '<(touchui)',
49 'webui_dialogs%': '<(webui_dialogs)',
44 'views_compositor%': '<(views_compositor)', 50 'views_compositor%': '<(views_compositor)',
45 'use_aura%': '<(use_aura)', 51 'use_aura%': '<(use_aura)',
46 52
47 # Compute the architecture that we're building on. 53 # Compute the architecture that we're building on.
48 'conditions': [ 54 'conditions': [
49 [ 'OS=="win" or OS=="mac"', { 55 [ 'OS=="win" or OS=="mac"', {
50 'host_arch%': 'ia32', 56 'host_arch%': 'ia32',
51 }, { 57 }, {
52 # This handles the Unix platforms for which there is some support. 58 # This handles the Unix platforms for which there is some support.
53 # Anything else gets passed through, which probably won't work very 59 # Anything else gets passed through, which probably won't work very
(...skipping 10 matching lines...) Expand all
64 'toolkit_views%': 0, 70 'toolkit_views%': 0,
65 }], 71 }],
66 72
67 # Views are always Pure in Touch case. 73 # Views are always Pure in Touch case.
68 ['touchui==1', { 74 ['touchui==1', {
69 'use_only_pure_views%': 1, 75 'use_only_pure_views%': 1,
70 }, { 76 }, {
71 'use_only_pure_views%': 0, 77 'use_only_pure_views%': 0,
72 }], 78 }],
73 79
80 # Use WebUI dialogs in TouchUI and PureView builds.
81 ['touchui==1 or use_only_pure_views==1', {
82 'webui_dialogs%': 1,
83 }],
84
74 # Use the views compositor when using the Aura window manager. 85 # Use the views compositor when using the Aura window manager.
75 ['use_aura==1', { 86 ['use_aura==1', {
76 'views_compositor%': 1, 87 'views_compositor%': 1,
77 }], 88 }],
78 ], 89 ],
79 }, 90 },
80 91
81 # Copy conditionally-set variables out one scope. 92 # Copy conditionally-set variables out one scope.
82 'chromeos%': '<(chromeos)', 93 'chromeos%': '<(chromeos)',
83 'touchui%': '<(touchui)', 94 'touchui%': '<(touchui)',
95 'webui_dialogs%': '<(webui_dialogs)',
84 'host_arch%': '<(host_arch)', 96 'host_arch%': '<(host_arch)',
85 'toolkit_views%': '<(toolkit_views)', 97 'toolkit_views%': '<(toolkit_views)',
86 'use_only_pure_views%': '<(use_only_pure_views)', 98 'use_only_pure_views%': '<(use_only_pure_views)',
87 'views_compositor%': '<(views_compositor)', 99 'views_compositor%': '<(views_compositor)',
88 'use_aura%': '<(use_aura)', 100 'use_aura%': '<(use_aura)',
89 101
90 # We used to provide a variable for changing how libraries were built. 102 # We used to provide a variable for changing how libraries were built.
91 # This variable remains until we can clean up all the users. 103 # This variable remains until we can clean up all the users.
92 # This needs to be one nested variables dict in so that dependent 104 # This needs to be one nested variables dict in so that dependent
93 # gyp files can make use of it in their outer variables. (Yikes!) 105 # gyp files can make use of it in their outer variables. (Yikes!)
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 'use_aura%': '<(use_aura)', 298 'use_aura%': '<(use_aura)',
287 'os_posix%': '<(os_posix)', 299 'os_posix%': '<(os_posix)',
288 'toolkit_uses_gtk%': '<(toolkit_uses_gtk)', 300 'toolkit_uses_gtk%': '<(toolkit_uses_gtk)',
289 'use_skia%': '<(use_skia)', 301 'use_skia%': '<(use_skia)',
290 'use_x11%': '<(use_x11)', 302 'use_x11%': '<(use_x11)',
291 'use_gnome_keyring%': '<(use_gnome_keyring)', 303 'use_gnome_keyring%': '<(use_gnome_keyring)',
292 'linux_fpic%': '<(linux_fpic)', 304 'linux_fpic%': '<(linux_fpic)',
293 'enable_flapper_hacks%': '<(enable_flapper_hacks)', 305 'enable_flapper_hacks%': '<(enable_flapper_hacks)',
294 'chromeos%': '<(chromeos)', 306 'chromeos%': '<(chromeos)',
295 'touchui%': '<(touchui)', 307 'touchui%': '<(touchui)',
308 'webui_dialogs%': '<(webui_dialogs)',
296 'file_manager_extension%': '<(file_manager_extension)', 309 'file_manager_extension%': '<(file_manager_extension)',
297 'webui_task_manager%': '<(webui_task_manager)', 310 'webui_task_manager%': '<(webui_task_manager)',
298 'inside_chromium_build%': '<(inside_chromium_build)', 311 'inside_chromium_build%': '<(inside_chromium_build)',
299 'fastbuild%': '<(fastbuild)', 312 'fastbuild%': '<(fastbuild)',
300 'python_ver%': '<(python_ver)', 313 'python_ver%': '<(python_ver)',
301 'armv7%': '<(armv7)', 314 'armv7%': '<(armv7)',
302 'arm_neon%': '<(arm_neon)', 315 'arm_neon%': '<(arm_neon)',
303 'sysroot%': '<(sysroot)', 316 'sysroot%': '<(sysroot)',
304 'disable_sse2%': '<(disable_sse2)', 317 'disable_sse2%': '<(disable_sse2)',
305 'component%': '<(component)', 318 'component%': '<(component)',
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 }], 661 }],
649 ['use_only_pure_views==1', { 662 ['use_only_pure_views==1', {
650 'grit_defines': ['-D', 'use_only_pure_views'], 663 'grit_defines': ['-D', 'use_only_pure_views'],
651 }], 664 }],
652 ['use_aura==1', { 665 ['use_aura==1', {
653 'grit_defines': ['-D', 'use_aura'], 666 'grit_defines': ['-D', 'use_aura'],
654 }], 667 }],
655 ['touchui==1', { 668 ['touchui==1', {
656 'grit_defines': ['-D', 'touchui'], 669 'grit_defines': ['-D', 'touchui'],
657 }], 670 }],
671 ['webui_dialogs==1', {
672 'grit_defines': ['-D', 'webui_dialogs'],
673 }],
658 ['file_manager_extension==1', { 674 ['file_manager_extension==1', {
659 'grit_defines': ['-D', 'file_manager_extension'], 675 'grit_defines': ['-D', 'file_manager_extension'],
660 }], 676 }],
661 ['webui_task_manager==1', { 677 ['webui_task_manager==1', {
662 'grit_defines': ['-D', 'webui_task_manager'], 678 'grit_defines': ['-D', 'webui_task_manager'],
663 }], 679 }],
664 ['remoting==1', { 680 ['remoting==1', {
665 'grit_defines': ['-D', 'remoting'], 681 'grit_defines': ['-D', 'remoting'],
666 }], 682 }],
667 ['use_titlecase_in_grd_files==1', { 683 ['use_titlecase_in_grd_files==1', {
(...skipping 1368 matching lines...) Expand 10 before | Expand all | Expand 10 after
2036 # settings in target dicts. SYMROOT is a special case, because many other 2052 # settings in target dicts. SYMROOT is a special case, because many other
2037 # Xcode variables depend on it, including variables such as 2053 # Xcode variables depend on it, including variables such as
2038 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 2054 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
2039 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 2055 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
2040 # files to appear (when present) in the UI as actual files and not red 2056 # files to appear (when present) in the UI as actual files and not red
2041 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 2057 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
2042 # and therefore SYMROOT, needs to be set at the project level. 2058 # and therefore SYMROOT, needs to be set at the project level.
2043 'SYMROOT': '<(DEPTH)/xcodebuild', 2059 'SYMROOT': '<(DEPTH)/xcodebuild',
2044 }, 2060 },
2045 } 2061 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_context_menu_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698