Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/spellchecker/spellcheck_host.cc

Issue 7919003: Remove refptr usages from SpellCheckHost (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix pointer returns. Update tests. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_host.h ('k') | chrome/browser/spellchecker/spellcheck_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/spellcheck_host.cc
diff --git a/chrome/browser/spellchecker/spellcheck_host.cc b/chrome/browser/spellchecker/spellcheck_host.cc
index bfdad0fad4422b538eb1b3b35e15c681ebed4510..32a1d7bda3cce399a8dc803a47b9e6eeacc7af87 100644
--- a/chrome/browser/spellchecker/spellcheck_host.cc
+++ b/chrome/browser/spellchecker/spellcheck_host.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/spellchecker/spellcheck_host.h"
+#include "base/memory/scoped_ptr.h"
dcheng 2011/10/20 23:24:34 I'm surprised you need to add this as we don't eve
#include "base/string_split.h"
#include "base/synchronization/waitable_event.h"
#include "chrome/browser/prefs/pref_member.h"
@@ -23,21 +24,19 @@ SpellCheckHost::EventType g_status_type = SpellCheckHost::BDICT_NOTINITIALIZED;
} // namespace
// static
-scoped_refptr<SpellCheckHost> SpellCheckHost::Create(
+SpellCheckHost* SpellCheckHost::Create(
SpellCheckProfileProvider* profile,
const std::string& language,
net::URLRequestContextGetter* request_context_getter,
SpellCheckHostMetrics* metrics) {
- scoped_refptr<SpellCheckHostImpl> host =
- new SpellCheckHostImpl(profile,
- language,
- request_context_getter,
+ SpellCheckHostImpl* host =
+ new SpellCheckHostImpl(profile, language, request_context_getter,
metrics);
if (!host)
return NULL;
host->Initialize();
- return host;
+ return (SpellCheckHost*)host;
dcheng 2011/10/20 23:24:34 You shouldn't need this cast.
}
// static
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_host.h ('k') | chrome/browser/spellchecker/spellcheck_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698