Remove refptr usages from SpellCheckHost

chrome/browser/spellchecker/spellcheck_host_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_HOST_IMPL_H_
 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_HOST_IMPL_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
+#include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "chrome/browser/spellchecker/spellcheck_host.h"
 #include "chrome/browser/spellchecker/spellcheck_profile_provider.h"
 #include "content/public/common/url_fetcher_delegate.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
 // This class implements the SpellCheckHost interface to provide the
 // functionalities listed below:
 // * Adding a word to the custom dictionary;
 // * Storing the custom dictionary to the file, and read it back
@@ skipping 15 matching lines @@
 // can be listed using SpellCheckHost::GetAvailableLanguages() static method.
 class SpellCheckHostImpl : public SpellCheckHost,
                            public content::URLFetcherDelegate,
                            public content::NotificationObserver {
  public:
   SpellCheckHostImpl(SpellCheckProfileProvider* profile,
                      const std::string& language,
                      net::URLRequestContextGetter* request_context_getter,
                      SpellCheckHostMetrics* metrics);
 
+  virtual ~SpellCheckHostImpl();
+
   void Initialize();
 
   // SpellCheckHost implementation
-  virtual void UnsetProfile();
-  virtual void InitForRenderer(RenderProcessHost* process);
-  virtual void AddWord(const std::string& word);
-  virtual const base::PlatformFile& GetDictionaryFile() const;
-  virtual const std::string& GetLanguage() const;
-  virtual bool IsUsingPlatformChecker() const;
+  virtual void UnsetProfile() OVERRIDE;
+  virtual void InitForRenderer(RenderProcessHost* process) OVERRIDE;
+  virtual void AddWord(const std::string& word) OVERRIDE;
+  virtual const base::PlatformFile& GetDictionaryFile() const OVERRIDE;
+  virtual const std::string& GetLanguage() const OVERRIDE;
+  virtual bool IsUsingPlatformChecker() const OVERRIDE;
 
  private:
   typedef SpellCheckProfileProvider::CustomWordList CustomWordList;
 
   // These two classes can destruct us.
   friend class content::BrowserThread;
   friend class DeleteTask<SpellCheckHostImpl>;
 
-  virtual ~SpellCheckHostImpl();
-
   // Figure out the location for the dictionary. This is only non-trivial for
   // Windows:
   // The default place whether the spellcheck dictionary can reside is
   // chrome::DIR_APP_DICTIONARIES. However, for systemwide installations,
   // this directory may not have permissions for download. In that case, the
   // alternate directory for download is chrome::DIR_USER_DATA.
   void InitializeDictionaryLocation();
+  void InitializeDictionaryLocationComplete();
 
-  // Load and parse the custom words dictionary and open the bdic file.
-  // Executed on the file thread.
-  void InitializeInternal();
-
-  void InitializeOnFileThread();
+  void AddWordComplete(const std::string& word);

[Hironori Bono, 2011/11/08 07:20:25]

nit: can you add a comment for this function, such as 'Called when we finish
adding a word in the background'?

 
   // Inform |profile_| that initialization has finished.
   // |custom_words| holds the custom word list which was
   // loaded at the file thread.
   void InformProfileOfInitializationWithCustomWords(
       CustomWordList* custom_words);
 
   // An alternative version of InformProfileOfInitializationWithCustomWords()
   // which implies empty |custom_words|.
   void InformProfileOfInitialization();
@@ skipping 18 matching lines @@
   // downloading the spellcheck dictionary; saves the dictionary to |data_|.
   virtual void OnURLFetchComplete(const content::URLFetcher* source);
 
   // NotificationProfile implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details);
 
   // Saves |data_| to disk. Run on the file thread.
   void SaveDictionaryData();
+  void SaveDictionaryDataComplete();
 
   // Verifies the specified BDict file exists and it is sane. This function
   // should be called before opening the file so we can delete it and download a
   // new dictionary if it is corrupted.
   bool VerifyBDict(const FilePath& path) const;
 
   // May be NULL.
   SpellCheckProfileProvider* profile_;
 
   // The desired location of the dictionary file (whether or not t exists yet).
   FilePath bdict_file_path_;
 
   // The location of the custom words file.
   FilePath custom_dictionary_file_;
 
+  bool dictionary_saved_;

[Hironori Bono, 2011/11/08 07:20:25]

nit: can you add a comment for this variable, such as 'Whether we successfully
download a dictionary and save it. This variable is used in a callback function
SaveDictionaryDataComplete()'?

+
   // The language of the dictionary file.
   std::string language_;
 
   // The file descriptor/handle for the dictionary file.
   base::PlatformFile file_;
 
   // We don't want to attempt to download a missing dictionary file more than
   // once.
   bool tried_to_download_;
 
   // Whether we should use the platform spellchecker instead of Hunspell.
   bool use_platform_spellchecker_;
 
   // Data received from the dictionary download.
   std::string data_;
 
   // Used for downloading the dictionary file. We don't hold a reference, and
   // it is only valid to use it on the UI thread.
   net::URLRequestContextGetter* request_context_getter_;
 
   // Used for downloading the dictionary file.
   scoped_ptr<content::URLFetcher> fetcher_;
 
   content::NotificationRegistrar registrar_;
 
   // An optional metrics counter given by the constructor.
   SpellCheckHostMetrics* metrics_;
 
+  base::WeakPtrFactory<SpellCheckHostImpl> weak_ptr_factory_;
+
+  scoped_ptr<CustomWordList> custom_words_;
+
   DISALLOW_COPY_AND_ASSIGN(SpellCheckHostImpl);
 };
 
 #endif  // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_HOST_IMPL_H_