test cases for server directed error handling code.

chrome/browser/sync/profile_sync_service_harness.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 62 matching lines @@
 
   // Blocks the caller until the datatype manager is configured and sync has
   // been initialized (for example, after a browser restart).  Returns true if
   // the wait was successful.
   bool AwaitSyncRestart();
 
   // Blocks the caller until this harness has completed a single sync cycle
   // since the previous one.  Returns true if a sync cycle has completed.
   bool AwaitSyncCycleCompletion(const std::string& reason);
 
   // Blocks the caller until the sync has been disabled for this client. Returns

[Raghu Simha, 2011/09/16 04:01:02]

While you're at it:  s/the sync/sync/

[lipalani1, 2011/09/19 18:59:13]

Done.

   // true if sync is disabled.
   bool AwaitSyncDisabled(const std::string& reason);
 
   // Blocks the caller until exponential backoff has been verified to happen.
   bool AwaitExponentialBackoffVerification();
 
+  // Blocks the caller until the syncer receives a actionable error.

[Raghu Simha, 2011/09/16 04:01:02]

nit: s/a actionable/an actionable/

[Raghu Simha, 2011/09/16 04:01:02]

Add "Returns true when so-and-so happens" to this comment.

[lipalani1, 2011/09/19 18:59:13]

Done.

[lipalani1, 2011/09/19 18:59:13]

Done.

+  bool AwaitActionableError();
+
   // Blocks until the given set of data types are migrated.
   bool AwaitMigration(const syncable::ModelTypeSet& expected_migrated_types);
 
   // Blocks the caller until this harness has observed that the sync engine
   // has downloaded all the changes seen by the |partner| harness's client.
   bool WaitUntilTimestampMatches(
       ProfileSyncServiceHarness* partner, const std::string& reason);
 
   // Calling this acts as a barrier and blocks the caller until |this| and
   // |partner| have both completed a sync cycle.  When calling this method,
@@ skipping 113 matching lines @@
     // The sync client is in the exponential backoff mode. Verify that
     // backoffs are triggered correctly.
     WAITING_FOR_EXPONENTIAL_BACKOFF_VERIFICATION,
 
     // The sync client is waiting for migration to start.
     WAITING_FOR_MIGRATION_TO_START,
 
     // The sync client is waiting for migration to finish.
     WAITING_FOR_MIGRATION_TO_FINISH,
 
+    // The sync client is waiting for an actionable error from server.

[Raghu Simha, 2011/09/16 04:01:02]

nit: s/from server/from the server/

[lipalani1, 2011/09/19 18:59:13]

Done.

+    WAITING_FOR_ACTIONABLE_ERROR,
+
     // The client verification is complete. We don't care about the state of
     // the syncer any more.
     WAITING_FOR_NOTHING,
 
     // The sync client needs a passphrase in order to decrypt data.
     SET_PASSPHRASE_FAILED,
 
     // The sync client cannot reach the server.
     SERVER_UNREACHABLE,
 
@@ skipping 80 matching lines @@
   const std::string profile_debug_name_;
 
   // Keeps track of the number of attempts at exponential backoff and its
   // related bookkeeping information for verification.
   browser_sync::RetryVerifier retry_verifier_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceHarness);
 };
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_