test cases for server directed error handling code.

chrome/browser/sync/profile_sync_service_harness.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <iterator>
 #include <ostream>
@@ skipping 345 matching lines @@
       }
       break;
     }
     case WAITING_FOR_EXPONENTIAL_BACKOFF_VERIFICATION: {
       VLOG(1) << GetClientInfoString(
                      "WAITING_FOR_EXPONENTIAL_BACKOFF_VERIFICATION");
       const browser_sync::sessions::SyncSessionSnapshot *snap =
           GetLastSessionSnapshot();
       CHECK(snap);
       retry_verifier_.VerifyRetryInterval(*snap);
       if (retry_verifier_.done())

[Raghu Simha, 2011/09/16 04:01:02]

While you're at it: Add a comment here that briefly explains why we are
signaling that the wait is complete. See states above for an example.

[lipalani1, 2011/09/19 18:59:13]

Done.

         SignalStateCompleteWithNextState(WAITING_FOR_NOTHING);
       break;
     }
     case WAITING_FOR_MIGRATION_TO_START: {
       VLOG(1) << GetClientInfoString("WAITING_FOR_MIGRATION_TO_START");
       if (HasPendingBackendMigration()) {
         SignalStateCompleteWithNextState(WAITING_FOR_MIGRATION_TO_FINISH);

[Raghu Simha, 2011/09/16 04:01:02]

While you're at it: Add a comment here that briefly explains why we are
signaling that the wait is complete. See states above for an example.

[lipalani1, 2011/09/19 18:59:13]

Done.

       }
       break;
     }
     case WAITING_FOR_MIGRATION_TO_FINISH: {
       VLOG(1) << GetClientInfoString("WAITING_FOR_MIGRATION_TO_FINISH");
       if (!HasPendingBackendMigration()) {

[Raghu Simha, 2011/09/16 04:01:02]

While you're at it: Add a comment here that briefly explains why we are
signaling that the wait is complete. See states above for an example.

[lipalani1, 2011/09/19 18:59:13]

Done.

         SignalStateCompleteWithNextState(WAITING_FOR_NOTHING);
       }
       break;
     }
+    case WAITING_FOR_ACTIONABLE_ERROR: {
+      VLOG(1) << GetClientInfoString("WAITING_FOR_ACTIONABLE_ERROR");
+      ProfileSyncService::Status status = GetStatus();
+      if (status.sync_protocol_error.action != browser_sync::UNKNOWN_ACTION &&
+          service_->unrecoverable_error_detected() == true) {

[Raghu Simha, 2011/09/16 04:01:02]

Add a comment here that briefly explains why we are signaling that the wait is
complete. See states above for an example.

[lipalani1, 2011/09/19 18:59:13]

Done.

+        SignalStateCompleteWithNextState(WAITING_FOR_NOTHING);
+      }
+      break;
+    }
     case SERVER_UNREACHABLE: {
       VLOG(1) << GetClientInfoString("SERVER_UNREACHABLE");
       if (GetStatus().server_reachable) {
         // The client was offline due to the network being disabled, but is now
         // back online. Wait for the pending sync cycle to complete.
         SignalStateCompleteWithNextState(WAITING_FOR_SYNC_TO_FINISH);
       }
       break;
     }
     case SET_PASSPHRASE_FAILED: {
@@ skipping 181 matching lines @@
   const browser_sync::sessions::SyncSessionSnapshot *snap =
       GetLastSessionSnapshot();
   CHECK(snap);
   retry_verifier_.Initialize(*snap);
   wait_state_ = WAITING_FOR_EXPONENTIAL_BACKOFF_VERIFICATION;
   AwaitStatusChangeWithTimeout(kExponentialBackoffVerificationTimeoutMs,
       "Verify Exponential backoff");
   return (retry_verifier_.Succeeded());
 }
 
+bool ProfileSyncServiceHarness::AwaitActionableError() {
+  ProfileSyncService::Status status = GetStatus();
+  DCHECK(status.sync_protocol_error.action == browser_sync::UNKNOWN_ACTION);

[Raghu Simha, 2011/09/16 04:01:02]

DCHECKs won't get executed on the main waterfall, because they run in release
mode. If this is important, consider using CHECK.

[lipalani1, 2011/09/19 18:59:13]

Done.

+  wait_state_ = WAITING_FOR_ACTIONABLE_ERROR;
+  AwaitStatusChangeWithTimeout(kLiveSyncOperationTimeoutMs,
+      "Waiting for actionable error");
+  status = GetStatus();
+  return (status.sync_protocol_error.action != browser_sync::UNKNOWN_ACTION &&
+          status.summary ==
+              browser_sync::SyncBackendHost::Status::OFFLINE_UNUSABLE);

[Raghu Simha, 2011/09/16 04:01:02]

Curious: This success conditions here seem to be different from the ones on
which you are waiting in RunStateChangeMachine. Should you also be waiting for
this condition in RunStateChangeMachine? Or change this to
unrecoverable_error_detected() == true?

[lipalani1, 2011/09/19 18:59:13]

Checking for unrecoverable error is the right thing. thanks for catching this.
On 2011/09/16 04:01:02, rsimha wrote:
Done.

+}
+
 bool ProfileSyncServiceHarness::AwaitMigration(
     const syncable::ModelTypeSet& expected_migrated_types) {
   VLOG(1) << GetClientInfoString("AwaitMigration");
   VLOG(1) << profile_debug_name_ << ": waiting until migration is done for "
           << syncable::ModelTypeSetToString(expected_migrated_types);
   while (true) {
     bool migration_finished =
         std::includes(migrated_types_.begin(), migrated_types_.end(),
                       expected_migrated_types.begin(),
                       expected_migrated_types.end());
@@ skipping 445 matching lines @@
   return (synced_types.count(type) != 0);
 }
 
 std::string ProfileSyncServiceHarness::GetServiceStatus() {
   DictionaryValue value;
   sync_ui_util::ConstructAboutInformation(service_, &value);
   std::string service_status;
   base::JSONWriter::Write(&value, true, &service_status);
   return service_status;
 }