Change the URL for the Extension Settings page from chrome://settings/extensionSettings to chrome...

Redirect chrome://extensions to the new chrome://settings/extensions (attempt 3).

I split up an API test because it times out (it is doing too much).

The other two modifications to the tests were needed because they were trying to open chrome://extensions in incognito.

In one case, the test just needed any page (so I switched to about:blank) and in the other we are testing for a condition that cannot happen anymorebecause chrome://extensions could be loaded in incognito but chrome://settingsdoesn't allow that -- it shunts the request to the non-incognito profile.

The test was testing that we don't crash in incognito, so I removed that test. Also change the URL for the Extension Settings page fromchrome://settings/extensionSettings  ->  chrome://settings/extensions.

BUG=87377, 96836
TEST=Well... type in chrome://extensions and notice it redirects.
TEST=chrome://settings/extensions (or chrome://extensions) should take you to the extension settings page, and chrome://settings/extensionSettings should not.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101804

[Finnur, 2011-09-19 17:55:40]

Rafael, can you take a look at 
chrome/browser/extensions/notifications_apitest.cc

I split it up into three tests in the hopes that is enough to take care of the
timeout.

The rest has already been reviewed and LG'ed, but the CL had to be reverted
since without this change the Notifications test times out (I can't repro the
problem, so I'm crossing my fingers it will work).

[rafaelw, 2011-09-19 18:12:00]

notifications_apitest lg

http://codereview.chromium.org/7918019/diff/8001/chrome/browser/extensions/no...
File chrome/browser/extensions/notifications_apitest.cc (right):

http://codereview.chromium.org/7918019/diff/8001/chrome/browser/extensions/no...
chrome/browser/extensions/notifications_apitest.cc:22: // Notifications not
supported on linux/views yet.
indent

http://codereview.chromium.org/7918019/diff/8001/chrome/browser/extensions/no...
chrome/browser/extensions/notifications_apitest.cc:31: // Notifications not
supported on linux/views yet.
indent

[Finnur, 2011-09-19 18:12:53]

Actually, I misspoke. 

The change has been LG'ed, except for the change from:

chrome://settings/extensionSettings
to
chrome://settings/extensions

Can you review all but the first three files (they are unchanged)?

[asargent_no_longer_on_chrome, 2011-09-19 18:17:10]

On 2011/09/19 18:12:53, Finnur wrote:
> Actually, I misspoke. 
> 
> The change has been LG'ed, except for the change from:
> 
> chrome://settings/extensionSettings
> to
> chrome://settings/extensions
> 
> Can you review all but the first three files (they are unchanged)?

LGTM