chrome/test/data/extensions/manifest_tests/intent_valid.json - Issue 7917006: Extension loading extracts intents from Manifest data.

Side by Side Diff: chrome/test/data/extensions/manifest_tests/intent_valid.json

Issue 7917006: Extension loading extracts intents from Manifest data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/extension.cc ('K') | « chrome/test/data/extensions/manifest_tests/intent_invalid_action_missing.json ('k') | chrome/test/data/extensions/manifest_tests/intent_valid_minimal.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "test",

	3 "version": "1",

	4 "intents": {

	5 "http://webintents.org/share" : {
	Greg Billock 2011/09/16 15:43:17 So the big difference from this to the schema in h So the big difference from this to the schema in https://github.com/mozilla/openwebapps/blob/develop/docs/ACTIVITIES.md is that one's keyed by action. Is the idea that keying by service URL is better because it may be that an app wants to install several urls for the same action? It seems more likely to me that the same service URL would handle multiple action types. groby-ooo-7-16 2011/09/16 17:40:37 I'm confused - this is modelled after the one in A Show quoted text On 2011/09/16 15:43:17, Greg Billock wrote: > So the big difference from this to the schema in > https://github.com/mozilla/openwebapps/blob/develop/docs/ACTIVITIES.md is that > one's keyed by action. Is the idea that keying by service URL is better because > it may be that an app wants to install several urls for the same action? It > seems more likely to me that the same service URL would handle multiple action > types. I'm confused - this is modelled after the one in ACTIVTIES.md. Straight from that page: services: { "http://webactivities.org/share": { type: [ "application/url", "text/", "image/" ] path: "/services/share.html" } } Yes, some key words are different - but that's just a suggestion, and easily changed. Greg Billock 2011/09/16 18:45:51 Perhaps I'm puzzled by 'action' appearing in the a Show quoted text On 2011/09/16 17:40:37, groby wrote: > On 2011/09/16 15:43:17, Greg Billock wrote: > > So the big difference from this to the schema in > > https://github.com/mozilla/openwebapps/blob/develop/docs/ACTIVITIES.md is that > > one's keyed by action. Is the idea that keying by service URL is better > because > > it may be that an app wants to install several urls for the same action? It > > seems more likely to me that the same service URL would handle multiple action > > types. > > I'm confused - this is modelled after the one in ACTIVTIES.md. Straight from > that page: > > services: { > "http://webactivities.org/share": { > type: [ "application/url", "text/", "image/" ] > path: "/services/share.html" > } > } > > Yes, some key words are different - but that's just a suggestion, and easily > changed. Perhaps I'm puzzled by 'action' appearing in the attribute list. In the Mozilla proposal, the url key is the action, and then in the attributes they have the service url (they call it 'path'). That they could both be urls is a bit confusing, but the semantics of the action url is the intent action, and the service url/path is what url the browser should load. groby-ooo-7-16 2011/09/17 01:14:42 No, you were right - I puzzled myself with this. F Show quoted text On 2011/09/16 18:45:51, Greg Billock wrote: > On 2011/09/16 17:40:37, groby wrote: > > On 2011/09/16 15:43:17, Greg Billock wrote: > > > So the big difference from this to the schema in > > > https://github.com/mozilla/openwebapps/blob/develop/docs/ACTIVITIES.md is > that > > > one's keyed by action. Is the idea that keying by service URL is better > > because > > > it may be that an app wants to install several urls for the same action? It > > > seems more likely to me that the same service URL would handle multiple > action > > > types. > > > > I'm confused - this is modelled after the one in ACTIVTIES.md. Straight from > > that page: > > > > services: { > > "http://webactivities.org/share": { > > type: [ "application/url", "text/", "image/" ] > > path: "/services/share.html" > > } > > } > > > > Yes, some key words are different - but that's just a suggestion, and easily > > changed. > > Perhaps I'm puzzled by 'action' appearing in the attribute list. In the Mozilla > proposal, the url key is the action, and then in the attributes they have the > service url (they call it 'path'). That they could both be urls is a bit > confusing, but the semantics of the action url is the intent action, and the > service url/path is what url the browser should load. No, you were right - I puzzled myself with this. Fixed up, key is now action, and the keyword is "path" instead of "action"
	6 "type" : "image/png",

	7 "action" : "/services/share",

	8 "title" : "Sample Sharing Intent",

	9 "disposition" : "inline"

	10 }

	11 }

	12 }

OLD	NEW