Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 7912002: Fix for Crash in AutofillProfileSyncableService::ActOnChange (Closed)

Created:
9 years, 3 months ago by GeorgeY
Modified:
9 years, 3 months ago
Reviewers:
Nicolas Zea, dhollowa
CC:
chromium-reviews, GeorgeY, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Fix for Crash in AutofillProfileSyncableService::ActOnChange BUG=96897 TEST=there should be no crash in error conditions. added a unit-test for that Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/sync/glue/autofill_profile_syncable_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_syncable_service_unittest.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
GeorgeY
9 years, 3 months ago (2011-09-16 23:18:51 UTC) #1
dhollowa
LGTM. Pending tries.
9 years, 3 months ago (2011-09-16 23:27:39 UTC) #2
Nicolas Zea
9 years, 3 months ago (2011-09-19 18:02:37 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698