Issue 7909012: Retry "Initial step into making Dependency thread safe""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7909012: Retry "Initial step into making Dependency thread safe"" (Closed)

Created:
9 years, 3 months ago by M-A Ruel

Modified:
9 years, 3 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power, Marc-Antoine Ruel (Google)

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Retry "Initial step into making Dependency thread safe"" I had forgot one access to _requirements. Now that tests are run, this change is safer to commit. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101856

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -13 lines)			Patch
M	gclient.py	View	5 chunks	+12 lines, -9 lines	0 comments	Download
M	gclient_utils.py	View	1 chunk	+29 lines, -3 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

M-A Ruel

btw, I verified this change passed the tests now that they are enabled.

9 years, 3 months ago (2011-09-16 14:43:50 UTC) #2

Marc-Antoine Ruel (Google)

On 2011/09/16 14:43:50, Marc-Antoine Ruel wrote: > btw, I verified this change passed the tests ...

9 years, 3 months ago (2011-09-19 22:52:09 UTC) #3

Change committed as 101856