Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 7906022: Merge theme_resources_large and theme_resources_standard targets (Closed)

Created:
9 years, 3 months ago by tony
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Merge theme_resources_large and theme_resources_standard targets into theme_resources. This gives us less .vcproj and .xcodeproject files on Win/Mac making things load a bit quicker. Also remove unused generated files from theme_resoures_large.grd. BUG=None TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101901

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M chrome/app/theme/theme_resources_large.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome.gyp View 5 chunks +0 lines, -18 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
9 years, 3 months ago (2011-09-16 16:23:13 UTC) #1
tony
ping + additional reviewer
9 years, 3 months ago (2011-09-19 16:53:23 UTC) #2
TVL
lgtm might want to tweak the cl description to cover the files you are dropping ...
9 years, 3 months ago (2011-09-19 16:59:11 UTC) #3
sail
LGTM
9 years, 3 months ago (2011-09-19 17:05:16 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-20 02:34:53 UTC) #5
Change committed as 101901

Powered by Google App Engine
This is Rietveld 408576698