Create a very simple TabContentsView (and not fully implemented yet) and add more supporting code...

Create a very simple TabContentsView (and not fully implemented yet) and add more supporting code to be able to load a page. Right now it's not rendering, but I suspect it's something small, and the patch has gotten large so I figure it's time to send it for review.

BUG=90445
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101395

[jam, 2011-09-15 18:05:28]

Will: shell_browser_context.*
Avi: everything else

[Avi (use Gerrit), 2011-09-15 18:12:49]

lgtm

How much of the TabContentViews are we looking to move from Chrome?

[jam, 2011-09-15 18:16:26]

On 2011/09/15 18:12:49, Avi wrote:
> lgtm
> 
> How much of the TabContentViews are we looking to move from Chrome?

If the chrome TabContentsView is possible to move to chrome (i.e. the gtk or mac
ones) then we can move them. But the Windows one was built on top of views, so
we couldn't move it

[willchan no longer on Chromium, 2011-09-15 18:17:24]

Sorry, flight got delayed. I'll look later in the afternoon when I land and
go to the office.
On Sep 15, 2011 11:12 AM, <avi@chromium.org> wrote:

[Avi (use Gerrit), 2011-09-15 18:22:09]

Oh. Didn't realize content didn't rely on views.

[willchan no longer on Chromium, 2011-09-15 22:01:28]

LGTM

It's very minimal, but I believe it's functionally correct. Some refactoring may
be warranted in the future, and it doesn't support everything yet, such as HTML5
schemes.

http://codereview.chromium.org/7906008/diff/1/content/shell/shell_browser_con...
File content/shell/shell_browser_context.cc (right):

http://codereview.chromium.org/7906008/diff/1/content/shell/shell_browser_con...
content/shell/shell_browser_context.cc:122: job_factory_.reset(new
net::URLRequestJobFactory);
In order to get web platform schemes like blob: and filesystem:, you will need
to add protocol handlers for them here. It sounds like the code for this in
profile_io_data.cc should be made public and put into content/browser. Perhaps a
content/browser/net is warranted for this.

http://codereview.chromium.org/7906008/diff/1/content/shell/shell_browser_con...
File content/shell/shell_browser_context.h (right):

http://codereview.chromium.org/7906008/diff/1/content/shell/shell_browser_con...
content/shell/shell_browser_context.h:73:
DISALLOW_COPY_AND_ASSIGN(ShellBrowserContext);
This is defined in basictypes.h