Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Side by Side Diff: chrome/browser/sync/js/js_event_details.h

Issue 7904021: [Sync] Rework SharedValue<T> into Immutable<T> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename vars Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_JS_JS_EVENT_DETAILS_H_ 5 #ifndef CHROME_BROWSER_SYNC_JS_JS_EVENT_DETAILS_H_
6 #define CHROME_BROWSER_SYNC_JS_JS_EVENT_DETAILS_H_ 6 #define CHROME_BROWSER_SYNC_JS_JS_EVENT_DETAILS_H_
7 #pragma once 7 #pragma once
8 8
9 // See README.js for design comments. 9 // See README.js for design comments.
10 10
11 #include <string> 11 #include <string>
12 12
13 #include "base/memory/ref_counted.h"
14 #include "base/values.h" 13 #include "base/values.h"
15 #include "chrome/browser/sync/util/shared_value.h" 14 #include "chrome/browser/sync/util/immutable.h"
16 15
17 namespace browser_sync { 16 namespace browser_sync {
18 17
19 // A thread-safe wrapper around an immutable DictionaryValue. Used 18 // A thin wrapper around Immutable<DictionaryValue>. Used for passing
20 // for passing around event details to different threads. 19 // around event details to different threads.
21 class JsEventDetails { 20 class JsEventDetails {
22 public: 21 public:
23 // Uses an empty dictionary. 22 // Uses an empty dictionary.
24 JsEventDetails(); 23 JsEventDetails();
25 24
26 // Takes over the data in |details|, leaving |details| empty. 25 // Takes over the data in |details|, leaving |details| empty.
27 explicit JsEventDetails(DictionaryValue* details); 26 explicit JsEventDetails(DictionaryValue* details);
28 27
29 ~JsEventDetails(); 28 ~JsEventDetails();
30 29
31 const DictionaryValue& Get() const; 30 const DictionaryValue& Get() const;
32 31
33 std::string ToString() const; 32 std::string ToString() const;
34 33
35 // Copy constructor and assignment operator welcome. 34 // Copy constructor and assignment operator welcome.
36 35
37 private: 36 private:
38 typedef SharedValue<DictionaryValue, HasSwapMemFnTraits<DictionaryValue> > 37 typedef Immutable<DictionaryValue, HasSwapMemFnByPtr<DictionaryValue> >
39 SharedDictionaryValue; 38 ImmutableDictionaryValue;
40 39
41 scoped_refptr<const SharedDictionaryValue> details_; 40 ImmutableDictionaryValue details_;
42 }; 41 };
43 42
44 } // namespace browser_sync 43 } // namespace browser_sync
45 44
46 #endif // CHROME_BROWSER_SYNC_JS_JS_EVENT_DETAILS_H_ 45 #endif // CHROME_BROWSER_SYNC_JS_JS_EVENT_DETAILS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698