Refactoring: move HasElementAtKey to ElementsAccessor

src/elements.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 173 matching lines @@
     return ElementsAccessorSubclass::GetCapacity(
         BackingStoreClass::cast(backing_store));
   }
 
   static bool HasElementAtIndex(BackingStoreClass* backing_store,
                                 uint32_t index,
                                 JSObject* holder,
                                 Object* receiver) {
     uint32_t key =
         ElementsAccessorSubclass::GetKeyForIndex(backing_store, index);
-    MaybeObject* element = ElementsAccessorSubclass::Get(backing_store,
-                                                         key,
-                                                         holder,
-                                                         receiver);
-    return !element->IsTheHole();
+    return ElementsAccessorSubclass::HasElementAtKey(
+        backing_store, key, holder, receiver);
   }
 
   virtual bool HasElementAtIndex(FixedArrayBase* backing_store,
                                  uint32_t index,
                                  JSObject* holder,
                                  Object* receiver) {
     return ElementsAccessorSubclass::HasElementAtIndex(
         BackingStoreClass::cast(backing_store), index, holder, receiver);
   }
 
+  static bool HasElementAtKey(BackingStoreClass* backing_store,
+                              uint32_t key,
+                              JSObject* holder,
+                              Object* receiver) {
+    MaybeObject* element = ElementsAccessorSubclass::Get(
+        backing_store, key, holder, receiver);
+    return !element->IsTheHole();
+  }
+
+  virtual bool HasElementAtKey(FixedArrayBase* backing_store,
+                               uint32_t key,
+                               JSObject* holder,
+                               Object* receiver) {
+    return ElementsAccessorSubclass::HasElementAtKey(
+        BackingStoreClass::cast(backing_store), key, holder, receiver);
+  }
+
   static uint32_t GetKeyForIndex(BackingStoreClass* backing_store,
                                  uint32_t index) {
     return index;
   }
 
   virtual uint32_t GetKeyForIndex(FixedArrayBase* backing_store,
-                                              uint32_t index) {
+                                  uint32_t index) {
     return ElementsAccessorSubclass::GetKeyForIndex(
         BackingStoreClass::cast(backing_store), index);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ElementsAccessorBase);
 };
 
 
 class FastElementsAccessor
@@ skipping 100 matching lines @@
       return backing_store->GetHeap()->undefined_value();
     }
   }
 
   virtual MaybeObject* Delete(JSObject* obj,
                               uint32_t key,
                               JSReceiver::DeleteMode mode) {
     // External arrays always ignore deletes.
     return obj->GetHeap()->true_value();
   }
+
+  static bool HasElementAtKey(ExternalArray* backing_store,
+                              uint32_t key,
+                              JSObject* holder,
+                              Object* receiver) {
+    return key < ExternalElementsAccessorSubclass::GetCapacity(backing_store);
+  }
 };
 
 
 class ExternalByteElementsAccessor
     : public ExternalElementsAccessor<ExternalByteElementsAccessor,
                                       ExternalByteArray> {
 };
 
 
 class ExternalUnsignedByteElementsAccessor
@@ skipping 279 matching lines @@
     &element_accessors.float_elements_handler,
     &element_accessors.double_elements_handler,
     &element_accessors.pixel_elements_handler
   };
 
   elements_accessors_ = accessor_array;
 }
 
 
 } }  // namespace v8::internal