Make file IO occur on the right thread.

Make file IO occur on the right thread.

BUG=chormium-os:20459
TEST=Change timezone in debug chrome build and it should not crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102095

[pastarmovj, 2011-09-15 11:47:00]

Hi can you please review this small change that makes file io code happen on the
right thread. Without this patch chrome compiled in debug mode crashes with an
IO on the wrong thread error.

I couldn't see any connection between the file set right and the calls to:

  icu::TimeZone::setDefault(timezone);
  FOR_EACH_OBSERVER(Observer, observers_, TimezoneChanged(timezone));

However if you think these two need the right file set we'll have to make sure
they don't get executed before the other function has been executed. WDYT?

[satorux1, 2011-09-19 16:49:03]

Sorry for the delayed response. Thank you for fixing this.

http://codereview.chromium.org/7904012/diff/1/chrome/browser/chromeos/system/...
File chrome/browser/chromeos/system/timezone_settings.cc (right):

http://codereview.chromium.org/7904012/diff/1/chrome/browser/chromeos/system/...
chrome/browser/chromeos/system/timezone_settings.cc:124:
BrowserThread::PostTask(BrowserThread::FILE,
I think it's safe to do SetTimezoneIDFromString() in the background, but this is
a bit tricky. Would be nice to add a comment like

Change the timezone config files in the FILE thread. It's safe to do this in the
background as the following operations don't depend on the completion of the
config change.

http://codereview.chromium.org/7904012/diff/1/chrome/browser/chromeos/system/...
chrome/browser/chromeos/system/timezone_settings.cc:126:
NewRunnableFunction(&SetTimezoneIDFromString, id));
Can you use base::Bind() instead? NewRunnableFunction is now deprecated.

[commit-bot: I haz the power, 2011-09-20 11:58:01]

No LGTM from valid reviewers yet.

[pastarmovj, 2011-09-20 12:04:12]

Addressed your comments. Trybots seem to be happy too :)

http://codereview.chromium.org/7904012/diff/1/chrome/browser/chromeos/system/...
File chrome/browser/chromeos/system/timezone_settings.cc (right):

http://codereview.chromium.org/7904012/diff/1/chrome/browser/chromeos/system/...
chrome/browser/chromeos/system/timezone_settings.cc:124:
BrowserThread::PostTask(BrowserThread::FILE,
On 2011/09/19 16:49:03, satorux1 wrote:
> I think it's safe to do SetTimezoneIDFromString() in the background, but this
is
> a bit tricky. Would be nice to add a comment like
> 
> Change the timezone config files in the FILE thread. It's safe to do this in
the
> background as the following operations don't depend on the completion of the
> config change.

Done.

http://codereview.chromium.org/7904012/diff/1/chrome/browser/chromeos/system/...
chrome/browser/chromeos/system/timezone_settings.cc:126:
NewRunnableFunction(&SetTimezoneIDFromString, id));
On 2011/09/19 16:49:03, satorux1 wrote:
> Can you use base::Bind() instead? NewRunnableFunction is now deprecated.

Done.

[satorux1, 2011-09-21 03:44:15]

LGTM++

[commit-bot: I haz the power, 2011-09-21 11:38:16]

Change committed as 102095