Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7904009: Reland r101269: Store plug-in enabled/disabled state in PluginPrefs instead of WebPluginInfo. (Closed)

Created:
9 years, 3 months ago by Bernhard Bauer
Modified:
9 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org, dpranke+watch-content_chromium.org, kkania, Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, cpu_(ooo_6.6-7.5), viettrungluu
Visibility:
Public.

Description

Reland r101269: Store plug-in enabled/disabled state in PluginPrefs instead of WebPluginInfo, to allow different sets of enabled/disabled plug-ins to be specified per profile. The relanded version fixes GViewRequestInterceptorTest on ChromeOS and a memory leak in PluginListTest.GetPluginGroup. Original review URL: http://codereview.chromium.org/7848025 TBR=jam@chromium.org BUG=80794 TEST=Open two profiles, disable different plugins in them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101297

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+656 lines, -1155 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 6 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/pdf_unsupported_feature.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/plugin_prefs.h View 3 chunks +56 lines, -30 lines 0 comments Download
M chrome/browser/plugin_prefs.cc View 13 chunks +247 lines, -107 lines 0 comments Download
A chrome/browser/plugin_prefs_unittest.cc View 1 chunk +160 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 9 chunks +107 lines, -31 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/common/pepper_plugin_registry.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/pepper_plugin_registry.cc View 2 chunks +1 line, -12 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_group.h View 6 chunks +6 lines, -96 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.cc View 7 chunks +9 lines, -357 lines 0 comments Download
M webkit/plugins/npapi/plugin_group_unittest.cc View 6 chunks +8 lines, -212 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 4 chunks +4 lines, -46 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 9 chunks +8 lines, -105 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 1 4 chunks +11 lines, -63 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/webplugininfo.h View 2 chunks +0 lines, -32 lines 0 comments Download
M webkit/plugins/webplugininfo.cc View 4 chunks +1 line, -10 lines 0 comments Download
M webkit/support/webkit_support_glue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bernhard Bauer
Please review. The original version is in patch set 1, and the fixed version in ...
9 years, 3 months ago (2011-09-15 12:38:05 UTC) #1
battre
On 2011/09/15 12:38:05, Bernhard Bauer wrote: > Please review. > > The original version is ...
9 years, 3 months ago (2011-09-15 13:05:43 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-15 15:33:47 UTC) #3 
Change committed as 101297

Powered by Google App Engine
This is Rietveld 408576698