Improve Tab-key navigation for editing Autofill addresses and credit cards.

chrome/browser/resources/options/inline_editable_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const DeletableItem = options.DeletableItem;
   const DeletableItemList = options.DeletableItemList;
 
   /**
    * Creates a new list item with support for inline editing.
@@ skipping 65 matching lines @@
       this.addEventListener('keydown', this.handleKeyDown_);
       this.addEventListener('leadChange', this.handleLeadChange_);
     },
 
     /** @inheritDoc */
     selectionChanged: function() {
       this.updateEditState();
     },
 
     /**
-     * Called when the input element receives focus. Selects this item in the
-     * list selection model.
-     * @private
-     */
-    handleFocus_: function() {
-      var list = this.parentNode;
-      var index = list.getIndexOfListItem(this);
-      list.selectionModel.selectedIndex = index;
-      list.selectionModel.anchorIndex = index;
-    },
-
-    /**
      * Called when this element gains or loses 'lead' status. Updates editing
      * mode accordingly.
      * @private
      */
     handleLeadChange_: function() {
       this.updateEditState();
     },
 
     /**
      * Updates the edit state based on the current selected and lead states.
@@ skipping 27 matching lines @@
         var focusElement = this.editClickTarget_ || this.initialFocusElement;
         this.editClickTarget_ = null;
 
         // When this is called in response to the selectedChange event,
         // the list grabs focus immediately afterwards. Thus we must delay
         // our focus grab.
         var self = this;
         if (focusElement) {
           window.setTimeout(function() {
             // Make sure we are still in edit mode by the time we execute.
-            if (self.editing && self.focusPlaceholder) {

[James Hawkins, 2011/09/19 23:00:07]

You're right. I checked it out, and this check is wrong and unnecessary if it
were modified to be correct (self.parent.focusPlaceholder).

+            if (self.editing) {
               focusElement.focus();
               focusElement.select();
             }
           }, 50);
         }
       } else {
         if (!this.editCancelled_ && this.hasBeenEdited &&
             this.currentInputIsValid) {
           if (this.isPlaceholder)
             this.parentNode.focusPlaceholder = true;
@@ skipping 261 matching lines @@
       return true;
     },
   };
 
   // Export
   return {
     InlineEditableItem: InlineEditableItem,
     InlineEditableItemList: InlineEditableItemList,
   };
 });