Improve Tab-key navigation for editing Autofill addresses and credit cards.

chrome/browser/resources/shared/js/cr/ui/list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: array_data_model.js
 // require: list_selection_model.js
 // require: list_selection_controller.js
 // require: list_item.js
 
 /**
@@ skipping 840 matching lines @@
 
       // We cache the list items since creating the DOM nodes is the most
       // expensive part of redrawing.
       var cachedItems = this.cachedItems_ || {};
       var newCachedItems = {};
 
       var desiredScrollHeight = this.getHeightsForIndex_(dataModel.length).top;
 
       var autoExpands = this.autoExpands_;
       var firstIndex = autoExpands ? 0 : this.getIndexForListOffset_(scrollTop);
-      // This is a bit tricky. We take the minimum of the available items to
-      // show and the number we want to show, so as not to go off the end of the
-      // list. For the number we want to show, we take the maximum of the number
-      // that would fit without a differently-sized lead item, and with one. We
-      // do this so that if the size of the lead item changes without a scroll
-      // event to trigger redrawing the list, we won't end up with empty space.

[Ilya Sherman, 2011/09/15 04:10:39]

This comment is also included within the implementation of
getItemsInViewPort()... no need to have it twice.

       var itemsInViewPort = this.getItemsInViewPort(itemHeight, firstIndex,
           scrollTop);
       var lastIndex = firstIndex + itemsInViewPort;
 
       this.textContent = '';
 
       this.beforeFiller_.style.height =
           this.getHeightsForIndex_(firstIndex).top + 'px';
       this.appendChild(this.beforeFiller_);
 
@@ skipping 68 matching lines @@
    * because list items can contain controls that can be focused, and for some
    * purposes (e.g., styling), the list can still be conceptually focused at
    * that point even though it doesn't actually have the page focus.
    */
   cr.defineProperty(List, 'hasElementFocus', cr.PropertyKind.BOOL_ATTR);
 
   return {
     List: List
   }
 });