Issue 79014: JavaScriptCore is not using the webkit common defines....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79014: JavaScriptCore is not using the webkit common defines.... (Closed)

Created:
11 years, 8 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
bradnelson, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

JavaScriptCore is not using the webkit common defines. In particular the USE_SYSTEM_MALLOC macros aren't properly defined. This turns out to be benign in our current builds, but will be significant with my future checkins. Overall, this checkin doesn't change anything, except to get the right definitions in place for JSC. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13871

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/build/JavaScriptCore/javascriptcore.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm; cc'ing Brad in case.

Expand Messages | Collapse Messages