test/cctest/test-heap.cc - Issue 7901016: Basic support for tracking smi-only arrays on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 7901016: Basic support for tracking smi-only arrays on ia32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ready to land Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index aeab4014b7453403706d3a2858aa0593aa170570..9a2e0177dc0273583f2d2186ce958922b6910d63 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -672,7 +672,8 @@ TEST(JSArray) {

// Set array length to 0.

ok = array->SetElementsLength(Smi::FromInt(0))->ToObjectChecked();

CHECK_EQ(Smi::FromInt(0), array->length());

- CHECK(array->HasFastElements()); // Must be in fast mode.

+ // Must be in fast mode.

+ CHECK(array->HasFastTypeElements());

// array[length] = name.

ok = array->SetElement(0, *name, kNonStrictMode, true)->ToObjectChecked();