Basic support for tracking smi-only arrays on ia32.

test/cctest/test-heap.cc

-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
 
 #include <stdlib.h>
 
 #include "v8.h"
 
 #include "execution.h"
 #include "factory.h"
 #include "macro-assembler.h"
 #include "global-handles.h"
 #include "cctest.h"
@@ skipping 653 matching lines @@
 
   // Allocate the object.
   Handle<JSObject> object = FACTORY->NewJSObject(function);
   Handle<JSArray> array = Handle<JSArray>::cast(object);
   // We just initialized the VM, no heap allocation failure yet.
   Object* ok = array->Initialize(0)->ToObjectChecked();
 
   // Set array length to 0.
   ok = array->SetElementsLength(Smi::FromInt(0))->ToObjectChecked();
   CHECK_EQ(Smi::FromInt(0), array->length());
-  CHECK(array->HasFastElements());  // Must be in fast mode.
+  // Must be in fast mode.
+  CHECK(array->HasFastElements() || array->HasFastSmiOnlyElements());

[Sven Panne, 2011/09/16 09:19:32]

This disjunction occurs quite frequently, perhaps introduce a separate HasFoo()
predicate for it?

[danno, 2011/09/21 14:32:04]

Done.

 
   // array[length] = name.
   ok = array->SetElement(0, *name, kNonStrictMode, true)->ToObjectChecked();
   CHECK_EQ(Smi::FromInt(1), array->length());
   CHECK_EQ(array->GetElement(0), *name);
 
   // Set array length with larger than smi value.
   Handle<Object> length =
       FACTORY->NewNumberFromUint(static_cast<uint32_t>(Smi::kMaxValue) + 1);
   ok = array->SetElementsLength(*length)->ToObjectChecked();
@@ skipping 634 matching lines @@
     CHECK(helper.b_found());
   }
   // ...but is now unreachable.
   {
     HeapIteratorTestHelper helper(a_saved, *b);
     helper.IterateHeap(HeapIterator::kFilterUnreachable);
     CHECK(!helper.a_found());
     CHECK(helper.b_found());
   }
 }