Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 7901016: Basic support for tracking smi-only arrays on ia32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix remaining failing tests Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2374 matching lines...) Expand 10 before | Expand all | Expand 10 after
2385 case EXTERNAL_UNSIGNED_INT_ELEMENTS: 2385 case EXTERNAL_UNSIGNED_INT_ELEMENTS:
2386 __ mov(result, operand); 2386 __ mov(result, operand);
2387 __ test(result, Operand(result)); 2387 __ test(result, Operand(result));
2388 // TODO(danno): we could be more clever here, perhaps having a special 2388 // TODO(danno): we could be more clever here, perhaps having a special
2389 // version of the stub that detects if the overflow case actually 2389 // version of the stub that detects if the overflow case actually
2390 // happens, and generate code that returns a double rather than int. 2390 // happens, and generate code that returns a double rather than int.
2391 DeoptimizeIf(negative, instr->environment()); 2391 DeoptimizeIf(negative, instr->environment());
2392 break; 2392 break;
2393 case EXTERNAL_FLOAT_ELEMENTS: 2393 case EXTERNAL_FLOAT_ELEMENTS:
2394 case EXTERNAL_DOUBLE_ELEMENTS: 2394 case EXTERNAL_DOUBLE_ELEMENTS:
2395 case FAST_SMI_ONLY_ELEMENTS:
2395 case FAST_ELEMENTS: 2396 case FAST_ELEMENTS:
2396 case FAST_DOUBLE_ELEMENTS: 2397 case FAST_DOUBLE_ELEMENTS:
2397 case DICTIONARY_ELEMENTS: 2398 case DICTIONARY_ELEMENTS:
2398 case NON_STRICT_ARGUMENTS_ELEMENTS: 2399 case NON_STRICT_ARGUMENTS_ELEMENTS:
2399 UNREACHABLE(); 2400 UNREACHABLE();
2400 break; 2401 break;
2401 } 2402 }
2402 } 2403 }
2403 } 2404 }
2404 2405
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
3156 case EXTERNAL_SHORT_ELEMENTS: 3157 case EXTERNAL_SHORT_ELEMENTS:
3157 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS: 3158 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
3158 __ mov_w(operand, value); 3159 __ mov_w(operand, value);
3159 break; 3160 break;
3160 case EXTERNAL_INT_ELEMENTS: 3161 case EXTERNAL_INT_ELEMENTS:
3161 case EXTERNAL_UNSIGNED_INT_ELEMENTS: 3162 case EXTERNAL_UNSIGNED_INT_ELEMENTS:
3162 __ mov(operand, value); 3163 __ mov(operand, value);
3163 break; 3164 break;
3164 case EXTERNAL_FLOAT_ELEMENTS: 3165 case EXTERNAL_FLOAT_ELEMENTS:
3165 case EXTERNAL_DOUBLE_ELEMENTS: 3166 case EXTERNAL_DOUBLE_ELEMENTS:
3167 case FAST_SMI_ONLY_ELEMENTS:
3166 case FAST_ELEMENTS: 3168 case FAST_ELEMENTS:
3167 case FAST_DOUBLE_ELEMENTS: 3169 case FAST_DOUBLE_ELEMENTS:
3168 case DICTIONARY_ELEMENTS: 3170 case DICTIONARY_ELEMENTS:
3169 case NON_STRICT_ARGUMENTS_ELEMENTS: 3171 case NON_STRICT_ARGUMENTS_ELEMENTS:
3170 UNREACHABLE(); 3172 UNREACHABLE();
3171 break; 3173 break;
3172 } 3174 }
3173 } 3175 }
3174 } 3176 }
3175 3177
(...skipping 1235 matching lines...) Expand 10 before | Expand all | Expand 10 after
4411 env->deoptimization_index()); 4413 env->deoptimization_index());
4412 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4414 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4413 } 4415 }
4414 4416
4415 4417
4416 #undef __ 4418 #undef __
4417 4419
4418 } } // namespace v8::internal 4420 } } // namespace v8::internal
4419 4421
4420 #endif // V8_TARGET_ARCH_IA32 4422 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698