Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/browser/component_updater/pepper_flash_component_installer.cc

Issue 7901015: Revert 101269 - Store plug-in enabled/disabled state in PluginPrefs instead of WebPluginInfo, to ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/pdf_unsupported_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/pepper_flash_component_installer.cc
===================================================================
--- chrome/browser/component_updater/pepper_flash_component_installer.cc (revision 101270)
+++ chrome/browser/component_updater/pepper_flash_component_installer.cc (working copy)
@@ -16,7 +16,6 @@
#include "base/stringprintf.h"
#include "base/values.h"
#include "chrome/browser/component_updater/component_updater_service.h"
-#include "chrome/browser/plugin_prefs.h"
#include "chrome/common/chrome_paths.h"
#include "content/browser/browser_thread.h"
#include "content/common/pepper_plugin_registry.h"
@@ -108,6 +107,7 @@
bool MakePepperFlashPluginInfo(const FilePath& flash_path,
const Version& flash_version,
bool out_of_process,
+ bool enabled,
PepperPluginInfo* plugin_info) {
if (!flash_version.IsValid())
return false;
@@ -119,6 +119,7 @@
plugin_info->is_out_of_process = out_of_process;
plugin_info->path = flash_path;
plugin_info->name = kFlashPluginName;
+ plugin_info->enabled = enabled;
// The description is like "Shockwave Flash 10.2 r154".
plugin_info->description = StringPrintf("%s %d.%d r%d",
@@ -142,9 +143,8 @@
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
PepperPluginInfo plugin_info;
// Register it as out-of-process and disabled.
- if (!MakePepperFlashPluginInfo(path, version, true, &plugin_info))
+ if (!MakePepperFlashPluginInfo(path, version, true, false, &plugin_info))
return;
- PluginPrefs::EnablePluginGlobally(false, plugin_info.path);
webkit::npapi::PluginList::Singleton()->RegisterInternalPlugin(
plugin_info.ToWebPluginInfo());
webkit::npapi::PluginList::Singleton()->RefreshPlugins();
Property changes on: chrome/browser/component_updater/pepper_flash_component_installer.cc
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/pdf_unsupported_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698