Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 790005: Modify WidgetWin::Init() such that it doesn't create the FocusManager if the ... (Closed)

Created:
10 years, 9 months ago by Marshall Greenblatt
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Modify WidgetWin::Init() such that it doesn't create the FocusManager if the window is style WS_CHILD and parented to the desktop. We intentionally set the parent to the desktop window to remove it from the FocusManager hierarchy while the window is hidden. BUG=37698 TEST=NONE Was: http://codereview.chromium.org/812004 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M views/widget/widget_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Marshall Greenblatt
Hi Jay, please review (from the correct source tree this time).
10 years, 9 months ago (2010-03-10 16:22:43 UTC) #1
jcampan
OK. (I am a bit worried we might be missing some other cases in the ...
10 years, 9 months ago (2010-03-10 17:35:58 UTC) #2
Marshall Greenblatt
10 years, 9 months ago (2010-03-10 17:48:02 UTC) #3
On 2010/03/10 17:35:58, jcampan wrote:
> OK.
> (I am a bit worried we might be missing some other cases in the future where a
> WidgetWin is not parented to either a WidgetWin or the desktop window. If this
> happens, then we'll have to change the code to do an explicit initialization
in
> that case).

Fair enough.  I'll commit this.

Powered by Google App Engine
This is Rietveld 408576698