Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 790004: Cut back the syntactic constructs handled by the flow graph builder. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Cut back the syntactic constructs handled by the flow graph builder. While the flow graph is experimental, it's easier to be able to ignore some problematic syntactic constructs. Reduce the ones that can occur in constructed flow graphs. Committed: http://code.google.com/p/v8/source/detail?r=4084

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -126 lines) Patch
M src/data-flow.cc View 1 9 chunks +63 lines, -126 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
10 years, 9 months ago (2010-03-10 13:20:16 UTC) #1
fschneider
http://codereview.chromium.org/790004/diff/1/2 File src/data-flow.cc (right): http://codereview.chromium.org/790004/diff/1/2#newcode172 src/data-flow.cc:172: if (lit->name()->IsEqualTo(CStrVector("cordicsincos"))) { This if-statement should be removed before ...
10 years, 9 months ago (2010-03-10 13:36:18 UTC) #2
fschneider
10 years, 9 months ago (2010-03-10 13:37:11 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698