Issue 7894: Set |contents_mime_type| early enough so that the encoding menu is enabled on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7894: Set |contents_mime_type| early enough so that the encoding menu is enabled on... (Closed)

Created:
12 years, 2 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set |contents_mime_type| early enough so that the encoding menu is enabled on the first load of a page in a tab. BUG=2929 TEST=Launch Chrome, go to www.google.com and make sure that the encoding menu is enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3844

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/browser/web_contents.cc	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

12 years, 2 months ago (2008-10-22 23:02:36 UTC) #2

LGTM with one change

http://codereview.chromium.org/7894/diff/1/2
File chrome/browser/web_contents.cc (right):

http://codereview.chromium.org/7894/diff/1/2#newcode688
Line 688: // Need to update MIME type here because it's referred to in
Can you move this block above the previous line of details (which logically goes
with the code below your addition), and put blank lines on each side of your
addition?

Expand Messages | Collapse Messages