Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6456)

Unified Diff: chrome/browser/webdata/web_database_migration_unittest.cc

Issue 7892048: Autofill: Remove fax number completely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_database_migration_unittest.cc
diff --git a/chrome/browser/webdata/web_database_migration_unittest.cc b/chrome/browser/webdata/web_database_migration_unittest.cc
index e6e73559a6ca575ddeb920b965d7859126cf7fd9..1fe0315140197433b0f6ce5f8f464591450bd727 100644
--- a/chrome/browser/webdata/web_database_migration_unittest.cc
+++ b/chrome/browser/webdata/web_database_migration_unittest.cc
@@ -51,7 +51,6 @@ void AutofillProfile31FromStatement(const sql::Statement& s,
profile->SetInfo(ADDRESS_HOME_ZIP, s.ColumnString16(11));
profile->SetInfo(ADDRESS_HOME_COUNTRY, s.ColumnString16(12));
profile->SetInfo(PHONE_HOME_WHOLE_NUMBER, s.ColumnString16(13));
- profile->SetInfo(PHONE_FAX_WHOLE_NUMBER, s.ColumnString16(14));
*date_modified = s.ColumnInt64(15);
profile->set_guid(s.ColumnString(16));
EXPECT_TRUE(guid::IsValidGUID(profile->guid()));
@@ -1167,10 +1166,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) {
EXPECT_EQ(ASCIIToUTF16("4151112222"), s4.ColumnString16(2));
// John Doe fax.
- ASSERT_TRUE(s4.Step());
- EXPECT_EQ("00580526-FF81-EE2A-0546-1AC593A32E2F", s4.ColumnString(0));
- EXPECT_EQ(1, s4.ColumnInt(1)); // 1 means phone.
- EXPECT_EQ(ASCIIToUTF16("4153334444"), s4.ColumnString16(2));
+ // Gets culled after fax type removed.
// John P. Doe phone.
// Gets culled during migration from 35 to 37 due to merging of John Doe and
@@ -1187,10 +1183,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) {
EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2));
// 2 Main Street fax.
- ASSERT_TRUE(s4.Step());
- EXPECT_EQ("4C74A9D8-7EEE-423E-F9C2-E7FA70ED1396", s4.ColumnString(0));
- EXPECT_EQ(1, s4.ColumnInt(1)); // 1 means fax.
- EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2));
+ // Gets culled after fax type removed.
// 2 Main St phone.
ASSERT_TRUE(s4.Step());
@@ -1199,10 +1192,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) {
EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2));
// 2 Main St fax.
- ASSERT_TRUE(s4.Step());
- EXPECT_EQ("722DF5C4-F74A-294A-46F0-31FFDED0D635", s4.ColumnString(0));
- EXPECT_EQ(1, s4.ColumnInt(1)); // 1 means fax.
- EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2));
+ // Gets culled after fax type removed.
// Note no phone or fax for Alfred E Newman.
@@ -1213,10 +1203,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) {
EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2));
// 2 Main St fax.
- ASSERT_TRUE(s4.Step());
- EXPECT_EQ("9E5FE298-62C7-83DF-6293-381BC589183F", s4.ColumnString(0));
- EXPECT_EQ(1, s4.ColumnInt(1)); // 1 means fax.
- EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2));
+ // Gets culled after fax type removed.
// Should be all.
EXPECT_FALSE(s4.Step());

Powered by Google App Engine
This is Rietveld 408576698