Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/autofill/personal_data_manager_mac.mm

Issue 7892048: Autofill: Remove fax number completely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/personal_data_manager_mac.mm
diff --git a/chrome/browser/autofill/personal_data_manager_mac.mm b/chrome/browser/autofill/personal_data_manager_mac.mm
index 66d68f9267bf4167bdfe697289623c65325a0ef7..58e3fcde28e09b87245b7cd51787935d49a5d763 100644
--- a/chrome/browser/autofill/personal_data_manager_mac.mm
+++ b/chrome/browser/autofill/personal_data_manager_mac.mm
@@ -91,7 +91,7 @@ void AuxiliaryProfilesImpl::GetAddressBookMeCard() {
// Fill in email information.
GetAddressBookEmail(me, addressLabelRaw, profile.get());
- // Fill in phone and fax number information.
+ // Fill in phone number information.
GetAddressBookPhoneNumbers(me, addressLabelRaw, profile.get());
profiles_.push_back(profile.release());
@@ -182,7 +182,7 @@ void AuxiliaryProfilesImpl::GetAddressBookEmail(
}
// Fills in telephone numbers. Each of these are special cases.
-// We match four cases: home/tel, home/fax, work/tel, work/fax.
+// We match two cases: home/tel, work/tel.
// Note, we traverse in reverse order so that top values in address book
// take priority.
void AuxiliaryProfilesImpl::GetAddressBookPhoneNumbers(
@@ -199,21 +199,11 @@ void AuxiliaryProfilesImpl::GetAddressBookPhoneNumbers(
string16 homePhone = base::SysNSStringToUTF16(
[phoneNumbers valueAtIndex:reverseK]);
profile->SetInfo(PHONE_HOME_WHOLE_NUMBER, homePhone);
- } else if ([addressLabelRaw isEqualToString:kABAddressHomeLabel] &&
- [phoneLabelRaw isEqualToString:kABPhoneHomeFAXLabel]) {
- string16 homeFax = base::SysNSStringToUTF16(
- [phoneNumbers valueAtIndex:reverseK]);
- profile->SetInfo(PHONE_FAX_WHOLE_NUMBER, homeFax);
} else if ([addressLabelRaw isEqualToString:kABAddressWorkLabel] &&
[phoneLabelRaw isEqualToString:kABPhoneWorkLabel]) {
string16 workPhone = base::SysNSStringToUTF16(
[phoneNumbers valueAtIndex:reverseK]);
profile->SetInfo(PHONE_HOME_WHOLE_NUMBER, workPhone);
- } else if ([addressLabelRaw isEqualToString:kABAddressWorkLabel] &&
- [phoneLabelRaw isEqualToString:kABPhoneWorkFAXLabel]) {
- string16 workFax = base::SysNSStringToUTF16(
- [phoneNumbers valueAtIndex:reverseK]);
- profile->SetInfo(PHONE_FAX_WHOLE_NUMBER, workFax);
} else if ([phoneLabelRaw isEqualToString:kABPhoneMobileLabel] ||
[phoneLabelRaw isEqualToString:kABPhoneMainLabel]) {
string16 phone = base::SysNSStringToUTF16(

Powered by Google App Engine
This is Rietveld 408576698