Autofill: Remove fax number completely.

chrome/browser/resources/options/autofill_edit_address_overlay.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
   const ArrayDataModel = cr.ui.ArrayDataModel;
 
   // The GUID of the loaded address.
   var guid;
@@ skipping 32 matching lines @@
       }
 
       self.guid = '';
       self.populateCountryList_();
       self.clearInputFields_();
       self.connectInputEvents_();
     },
 
     /**
      * Creates, decorates and initializes the multi-value lists for full name,
-     * phone, fax, and email.
+     * phone, and email.
      * @private
      */
     createMultiValueLists_: function() {
       var list = $('full-name-list');
       options.autofillOptions.AutofillValuesList.decorate(list);
       list.autoExpands = true;
 
       list = $('phone-list');
       options.autofillOptions.AutofillPhoneValuesList.decorate(list);
       list.autoExpands = true;
 
-      list = $('fax-list');
-      options.autofillOptions.AutofillFaxValuesList.decorate(list);
-      list.autoExpands = true;
-
       list = $('email-list');
       options.autofillOptions.AutofillValuesList.decorate(list);
       list.autoExpands = true;
     },
 
     /**
      * Updates the data model for the list named |listName| with the values from
      * |entries|.
      * @param {String} listName The id of the list.
      * @param {Array} entries The list of items to be added to the list.
@@ skipping 37 matching lines @@
       address[1] = list.dataModel.slice(0, list.dataModel.length - 1);
       address[2] = $('company-name').value;
       address[3] = $('addr-line-1').value;
       address[4] = $('addr-line-2').value;
       address[5] = $('city').value;
       address[6] = $('state').value;
       address[7] = $('postal-code').value;
       address[8] = $('country').value;
       list = $('phone-list');
       address[9] = list.dataModel.slice(0, list.dataModel.length - 1);
-      list = $('fax-list');
+      list = $('email-list');
       address[10] = list.dataModel.slice(0, list.dataModel.length - 1);
-      list = $('email-list');
-      address[11] = list.dataModel.slice(0, list.dataModel.length - 1);
 
       chrome.send('setAddress', address);
     },
 
     /**
      * Connects each input field to the inputFieldChanged_() method that enables
      * or disables the 'Ok' button based on whether all the fields are empty or
      * not.
      * @private
      */
@@ skipping 17 matching lines @@
      */
     inputFieldChanged_: function() {
       // Length of lists are tested for <= 1 due to the "add" placeholder item
       // in the list.
       var disabled =
           $('full-name-list').items.length <= 1 &&
           !$('company-name').value &&
           !$('addr-line-1').value && !$('addr-line-2').value &&
           !$('city').value && !$('state').value && !$('postal-code').value &&
           !$('country').value && $('phone-list').items.length <= 1 &&
-          $('fax-list').items.length <= 1 && $('email-list').items.length <= 1;
+          && $('email-list').items.length <= 1;

[Ilya Sherman, 2011/09/15 03:47:08]

extra '&&'

[James Hawkins, 2011/09/16 03:23:28]

Done.

       $('autofill-edit-address-apply-button').disabled = disabled;
     },
 
     /**
      * Updates the postal code and state field labels appropriately for the
      * selected country.
      * @private
      */
     countryChanged_: function() {
       var countryCode = $('country').value;
@@ skipping 63 matching lines @@
     clearInputFields_: function() {
       this.setMultiValueList_('full-name-list', []);
       $('company-name').value = '';
       $('addr-line-1').value = '';
       $('addr-line-2').value = '';
       $('city').value = '';
       $('state').value = '';
       $('postal-code').value = '';
       $('country').value = '';
       this.setMultiValueList_('phone-list', []);
-      this.setMultiValueList_('fax-list', []);
       this.setMultiValueList_('email-list', []);
 
       this.countryChanged_();
     },
 
     /**
      * Loads the address data from |address|, sets the input fields based on
      * this data and stores the GUID of the address.
      * @private
      */
@@ skipping 10 matching lines @@
     setInputFields_: function(address) {
       this.setMultiValueList_('full-name-list', address['fullName']);
       $('company-name').value = address['companyName'];
       $('addr-line-1').value = address['addrLine1'];
       $('addr-line-2').value = address['addrLine2'];
       $('city').value = address['city'];
       $('state').value = address['state'];
       $('postal-code').value = address['postalCode'];
       $('country').value = address['country'];
       this.setMultiValueList_('phone-list', address['phone']);
-      this.setMultiValueList_('fax-list', address['fax']);
       this.setMultiValueList_('email-list', address['email']);
 
       this.countryChanged_();
     },
   };
 
   AutofillEditAddressOverlay.clearInputFields = function() {
     AutofillEditAddressOverlay.getInstance().clearInputFields_();
   };
 
   AutofillEditAddressOverlay.loadAddress = function(address) {
     AutofillEditAddressOverlay.getInstance().loadAddress_(address);
   };
 
   AutofillEditAddressOverlay.setTitle = function(title) {
     $('autofill-address-title').textContent = title;
   };
 
   AutofillEditAddressOverlay.setValidatedPhoneNumbers = function(numbers) {
     AutofillEditAddressOverlay.getInstance().setMultiValueList_('phone-list',
                                                                 numbers);
   };
 
-  AutofillEditAddressOverlay.setValidatedFaxNumbers = function(numbers) {
-    AutofillEditAddressOverlay.getInstance().setMultiValueList_('fax-list',
-                                                                numbers);
-  };
-
   // Export
   return {
     AutofillEditAddressOverlay: AutofillEditAddressOverlay
   };
 });