Autofill: Remove fax number completely.

chrome/browser/autofill/phone_field.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/phone_field.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_field.h"
 #include "chrome/browser/autofill/autofill_scanner.h"
-#include "chrome/browser/autofill/fax_number.h"
 #include "chrome/browser/autofill/home_phone_number.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 const char kPhoneRe[] =
     "phone|mobile"
     // de-DE
     "|telefonnummer"
     // es
@@ skipping 13 matching lines @@
         "\xb4\xeb\x8c\x80\xed\x8f\xb0|\xed\x9c\xb4\xeb\x8c\x80\xec\xa0\x84\xed"
         "\x99\x94)(.?\xeb\xb2\x88\xed\x98\xb8)?";
 const char kCountryCodeRe[] =
     "country.*code|ccode|_cc";
 const char kAreaCodeNotextRe[] =
     "^\\($";
 const char kAreaCodeRe[] =
     "area.*code|acode|area"
     // ko-KR
     "|\xec\xa7\x80\xec\x97\xad.?\xeb\xb2\x88\xed\x98\xb8";
-const char kFaxRe[] =
-    "fax"
-    // fr-FR
-    "|t\xc3\xa9l\xc3\xa9""copie|telecopie"
-    // ja-JP
-    "|\xe3\x83\x95\xe3\x82\xa1\xe3\x83\x83\xe3\x82\xaf\xe3\x82\xb9"
-    // ru
-    "|\xd1\x84\xd0\xb0\xd0\xba\xd1\x81"
-    // zh-CN
-    "|\xe4\xbc\xa0\xe7\x9c\x9f"
-    // zh-TW
-    "|\xe5\x82\xb3\xe7\x9c\x9f"
-    // ko-KR
-    "|\xed\x8c\xa9\xec\x8a\xa4(.?\xeb\xb2\x88\xed\x98\xb8)?";
 const char kPhonePrefixSeparatorRe[] =
     "^-$|^\\)$";
 const char kPhoneSuffixSeparatorRe[] =
     "^-$";
 const char kPhonePrefixRe[] =
     "prefix|exchange"
     // fr-FR
     "|preselection"
     // pt-BR, pt-PT
     "|ddd";
@@ skipping 95 matching lines @@
 };
 
 PhoneField::~PhoneField() {}
 
 // static
 FormField* PhoneField::Parse(AutofillScanner* scanner) {
   if (scanner->IsEnd())
     return NULL;
 
   scoped_ptr<PhoneField> phone_field(new PhoneField);
-
-  // Go through the phones in order HOME, FAX, attempting to match. HOME should
-  // be the last as it is a catch all case ("fax" and "faxarea" parsed as FAX,
-  // but "area" and "someotherarea" parsed as HOME, for example).
-  for (int i = PHONE_TYPE_MAX - 1; i >= PHONE_TYPE_FIRST; --i) {
-    phone_field->SetPhoneType(static_cast<PhoneField::PhoneType>(i));
-    if (ParseInternal(phone_field.get(), scanner, i == HOME_PHONE))
-      return phone_field.release();
-  }
+  if (ParseInternal(phone_field.get(), scanner))
+    return phone_field.release();
 
   return NULL;
 }
 
 PhoneField::PhoneField() {
   memset(parsed_phone_fields_, 0, sizeof(parsed_phone_fields_));
-  SetPhoneType(HOME_PHONE);
+  number_.reset(new PhoneNumber(AutofillType::PHONE_HOME, NULL));
 }
 
 bool PhoneField::ClassifyField(FieldTypeMap* map) const {
   bool ok = true;
 
   DCHECK(parsed_phone_fields_[FIELD_PHONE]);  // Phone was correctly parsed.
 
   if ((parsed_phone_fields_[FIELD_COUNTRY_CODE] != NULL) ||
       (parsed_phone_fields_[FIELD_AREA_CODE] != NULL) ||
       (parsed_phone_fields_[FIELD_SUFFIX] != NULL)) {
@@ skipping 28 matching lines @@
   } else {
     ok = AddClassification(parsed_phone_fields_[FIELD_PHONE],
                            number_->GetWholeNumberType(),
                            map);
   }
 
   return ok;
 }
 
 string16  PhoneField::GetCountryRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kCountryCodeRe);
 }
 
 string16 PhoneField::GetAreaRegex() const {
-  // This one is the same for Home and Fax numbers.
   string16 area_code = UTF8ToUTF16(kAreaCodeRe);
   area_code.append(ASCIIToUTF16("|"));  // Regexp separator.
   area_code.append(GetAreaNoTextRegex());
   return area_code;
 }
 
 string16 PhoneField::GetAreaNoTextRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kAreaCodeNotextRe);
 }
 
 string16 PhoneField::GetPhoneRegex() const {
-  if (phone_type_ == HOME_PHONE)
-    return UTF8ToUTF16(kPhoneRe);
-  else if (phone_type_ == FAX_PHONE)
-    return UTF8ToUTF16(kFaxRe);
-  else
-    NOTREACHED();
-  return string16();
+  return UTF8ToUTF16(kPhoneRe);
 }
 
 string16 PhoneField::GetPrefixSeparatorRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kPhonePrefixSeparatorRe);
 }
 
 string16 PhoneField::GetPrefixRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kPhonePrefixRe);
 }
 
 string16 PhoneField::GetSuffixSeparatorRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kPhoneSuffixSeparatorRe);
 }
 
 string16 PhoneField::GetSuffixRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kPhoneSuffixRe);
 }
 
 string16 PhoneField::GetExtensionRegex() const {
-  // This one is the same for Home and Fax numbers.
   return UTF8ToUTF16(kPhoneExtensionRe);
 }
 
 string16 PhoneField::GetRegExp(RegexType regex_id) const {
   switch (regex_id) {
     case REGEX_COUNTRY: return GetCountryRegex();
     case REGEX_AREA: return GetAreaRegex();
     case REGEX_AREA_NOTEXT: return GetAreaNoTextRegex();
     case REGEX_PHONE: return GetPhoneRegex();
     case REGEX_PREFIX_SEPARATOR: return GetPrefixSeparatorRegex();
     case REGEX_PREFIX: return GetPrefixRegex();
     case REGEX_SUFFIX_SEPARATOR: return GetSuffixSeparatorRegex();
     case REGEX_SUFFIX: return GetSuffixRegex();
     case REGEX_EXTENSION: return GetExtensionRegex();
     default:
       NOTREACHED();
       break;
   }
   return string16();
 }
 
 // static
 bool PhoneField::ParseInternal(PhoneField *phone_field,
-                               AutofillScanner* scanner,
-                               bool regular_phone) {
+                               AutofillScanner* scanner) {
   DCHECK(phone_field);
   scanner->SaveCursor();
 
   // The form owns the following variables, so they should not be deleted.
   const AutofillField* parsed_fields[FIELD_MAX];
 
   for (size_t i = 0; i < arraysize(phone_field_grammars_); ++i) {
     memset(parsed_fields, 0, sizeof(parsed_fields));
     scanner->SaveCursor();
 
@@ skipping 53 matching lines @@
                  &phone_field->parsed_phone_fields_[FIELD_SUFFIX]);
     }
   }
 
   // Now look for an extension.
   ParseField(scanner, phone_field->GetExtensionRegex(),
              &phone_field->parsed_phone_fields_[FIELD_EXTENSION]);
 
   return true;
 }
-
-void PhoneField::SetPhoneType(PhoneType phone_type) {
-  // Field types are different as well, so we create a temporary phone number,
-  // to get relevant field types.
-  if (phone_type == HOME_PHONE)
-    number_.reset(new PhoneNumber(AutofillType::PHONE_HOME, NULL));
-  else
-    number_.reset(new PhoneNumber(AutofillType::PHONE_FAX, NULL));
-  phone_type_ = phone_type;
-}
-