Fix for .bind regression.

Fix for .bind regression.

R=jkummerow@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9267

[Jakob Kummerow, 2011-09-13 17:09:54]

LGTM with nits.

http://codereview.chromium.org/7892013/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/7892013/diff/1/src/execution.cc#newcode165
src/execution.cc:165: // For reasons that escape me, `global' can be the
JSBuiltinsObject
It's a nit, but please don't use accents for quoting, that hurts my eyes. Your
options:
- ‘proper’ typographic quotes (bad, because they're non-ASCII characters and
will confuse some compilers even in comments)
- 'regular' ASCII quote/apostrophe replacement characters
- the Chromium convention of |pipes| around identifiers in comments.

http://codereview.chromium.org/7892013/diff/1/test/mjsunit/regress/regress-bi...
File test/mjsunit/regress/regress-bind-receiver.js (right):

http://codereview.chromium.org/7892013/diff/1/test/mjsunit/regress/regress-bi...
test/mjsunit/regress/regress-bind-receiver.js:5:
assertEquals(strict.bind(true)(), true);
assertEquals takes the expected value as the first parameter and the actual
value as the second. (Less confusing error messages)++ ;-)

[rossberg, 2011-09-13 17:13:59]

http://codereview.chromium.org/7892013/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/7892013/diff/1/src/execution.cc#newcode165
src/execution.cc:165: // For reasons that escape me, `global' can be the
JSBuiltinsObject
On 2011/09/13 17:09:54, Jakob wrote:
> It's a nit, but please don't use accents for quoting, that hurts my eyes. Your
> options:
> - ‘proper’ typographic quotes (bad, because they're non-ASCII characters and
> will confuse some compilers even in comments)
> - 'regular' ASCII quote/apostrophe replacement characters
> - the Chromium convention of |pipes| around identifiers in comments.

Done.

http://codereview.chromium.org/7892013/diff/1/test/mjsunit/regress/regress-bi...
File test/mjsunit/regress/regress-bind-receiver.js (right):

http://codereview.chromium.org/7892013/diff/1/test/mjsunit/regress/regress-bi...
test/mjsunit/regress/regress-bind-receiver.js:5:
assertEquals(strict.bind(true)(), true);
On 2011/09/13 17:09:54, Jakob wrote:
> assertEquals takes the expected value as the first parameter and the actual
> value as the second. (Less confusing error messages)++ ;-)

Done. (Had C&P'ed this from Webkit.)