Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4547)

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 7892007: Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH to profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_browsertest.cc
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index 102a022b73e6862d993e592f0391e4a877fe4331..03ff8e5e7868fa8c125cae377a64d6c602a7865c 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -27,7 +27,6 @@
#include "chrome/test/base/testing_profile.h"
#include "content/browser/browser_thread.h"
#include "content/browser/renderer_host/mock_render_process_host.h"
-#include "content/browser/renderer_host/test_render_view_host.h"
#include "content/browser/tab_contents/navigation_details.h"
#include "content/browser/tab_contents/test_tab_contents.h"
#include "content/common/notification_details.h"
@@ -154,13 +153,13 @@ class TranslateManagerTest : public TabContentsWrapperTestHarness,
protected:
virtual void SetUp() {
// Access the TranslateManager singleton so it is created before we call
- // RenderViewHostTestHarness::SetUp() to match what's done in Chrome, where
- // the TranslateManager is created before the TabContents. This matters as
- // they both register for similar events and we want the notifications to
- // happen in the same sequence (TranslateManager first, TabContents second).
- // Also clears the translate script so it is fetched everytime and sets the
- // expiration delay to a large value by default (in case it was zeroed in
- // a previous test).
+ // TabContentsWrapperTestHarness::SetUp() to match what's done in Chrome,
+ // where the TranslateManager is created before the TabContents. This
+ // matters as they both register for similar events and we want the
+ // notifications to happen in the same sequence (TranslateManager first,
+ // TabContents second). Also clears the translate script so it is fetched
+ // everytime and sets the expiration delay to a large value by default (in
+ // case it was zeroed in a previous test).
TranslateManager::GetInstance()->ClearTranslateScript();
TranslateManager::GetInstance()->
set_translate_script_expiration_delay(60 * 60 * 1000);
« no previous file with comments | « chrome/browser/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698