chrome/browser/favicon/favicon_handler_unittest.cc - Issue 7892007: Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH to profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 7892007: Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH to profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/tab_specific_content_settings_unittest.cc ('K') | « chrome/browser/extensions/extension_webnavigation_unittest.cc ('k') | chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc » ('j') | chrome/browser/password_manager/password_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/favicon/favicon_handler_unittest.cc

diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc

index 8759a23a77ae95e5adda171003a6429feee9bc9e..91ef6f25f3a8075029ee6b61b5d3f0d2c9d81e07 100644

--- a/chrome/browser/favicon/favicon_handler_unittest.cc

+++ b/chrome/browser/favicon/favicon_handler_unittest.cc

@@ -4,7 +4,7 @@

#include "chrome/browser/favicon/favicon_handler.h"

#include "chrome/browser/profiles/profile.h"

-#include "content/browser/renderer_host/test_render_view_host.h"

+#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "content/browser/tab_contents/navigation_entry.h"

#include "content/browser/tab_contents/test_tab_contents.h"

#include "ui/gfx/codec/png_codec.h"

@@ -305,7 +305,7 @@ void HistoryRequestHandler::InvokeCallback() {

callback_->Run(0, favicon_data_);

}

-class FaviconHandlerTest : public RenderViewHostTestHarness {

+class FaviconHandlerTest : public ChromeRenderViewHostTestHarness {

};

TEST_F(FaviconHandlerTest, GetFaviconFromHistory) {