Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH to profile

chrome/browser/ui/tab_contents/test_tab_contents_wrapper.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tab_contents/test_tab_contents_wrapper.h"
 
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
 
 TabContentsWrapperTestHarness::TabContentsWrapperTestHarness()
-    : RenderViewHostTestHarness() {
+    : ChromeRenderViewHostTestHarness() {
 }
 
 TabContentsWrapperTestHarness::~TabContentsWrapperTestHarness() {
 }
 
 TestTabContents* TabContentsWrapperTestHarness::contents() {
   return contents_wrapper_.get() ?
       static_cast<TestTabContents*>(contents_wrapper_->tab_contents()) : NULL;
 }
 
 TabContentsWrapper* TabContentsWrapperTestHarness::contents_wrapper() {
   return contents_wrapper_.get();
 }
 
 void TabContentsWrapperTestHarness::SetContents(TestTabContents* contents) {
   contents_wrapper_.reset(contents ? new TabContentsWrapper(contents) : NULL);
 }
 
 void TabContentsWrapperTestHarness::SetUp() {
+  if (!browser_context_.get())

[Paweł Hajdan Jr., 2011/09/13 19:16:36]

Is this needed? Why don't we call ChromeRender...TestHarness::SetUp here?

[jochen (gone - plz use gerrit), 2011/09/13 19:39:36]

because that would create a "raw" tab contents. TabContentsWrapperTestHarness
overrides all those methods to use contents_wrapper_ instead

+    browser_context_.reset(new TestingProfile());
   SetContents(CreateTestTabContents());
 }
 
 void TabContentsWrapperTestHarness::TearDown() {
   contents_wrapper_.reset();
 
   // Make sure that we flush any messages related to TabContents destruction
-  // before we destroy the profile.
+  // before we destroy the browser context.
   MessageLoop::current()->RunAllPending();
 
-  // Release the profile on the UI thread.
-  message_loop_.DeleteSoon(FROM_HERE, profile_.release());
+  // Release the browser context on the UI thread.
+  message_loop_.DeleteSoon(FROM_HERE, browser_context_.release());
   message_loop_.RunAllPending();

[Paweł Hajdan Jr., 2011/09/13 19:16:36]

Why don't we call parent's TearDown here?

[jochen (gone - plz use gerrit), 2011/09/13 19:39:36]

because we didn't invoke the parent's setup

 }