Fix member lookup to be more stable.

Fix member lookup to be more stable.

Add regression test.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101351

[Dirk Pranke, 2011-09-14 21:37:14]

Wow, I understand nothing about this patch. What was the problem, why does your
change in gclient fix it, and what do the tests have to do with anything? :)

[M-A Ruel, 2011-09-14 22:56:55]

I made the test synthetic.

http://codereview.chromium.org/7891061/diff/1/gclient.py
File gclient.py (left):

http://codereview.chromium.org/7891061/diff/1/gclient.py#oldcode591
gclient.py:591: if self.__dict__[i]:
self.__dict__[i] will throw an exception if the member is not present. But I'm
about to convert most of time from foo to _foo so they can be locked but I don't
want to use foo when _foo is available since it'll incur locking.

http://codereview.chromium.org/7891061/diff/1/tests/gclient_test.py
File tests/gclient_test.py (right):

http://codereview.chromium.org/7891061/diff/1/tests/gclient_test.py#newcode256
tests/gclient_test.py:256: self.assertEquals(1874, len(str(obj)), '%d\n%s' %
(len(str(obj)), str(obj)))
The whole code above is to test this line.

[Dirk Pranke, 2011-09-15 19:05:53]

lgtm

Oh, I see, this is all in the __str__ method; I somehow thought that this was in
__get__ or something.

LGTM.

[commit-bot: I haz the power, 2011-09-15 19:17:23]

Change committed as 101351