Add GROUP_FILE ModelSafeGroup

chrome/browser/sync/glue/file_model_worker.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_GLUE_FILE_MODEL_WORKER_H_
+#define CHROME_BROWSER_SYNC_GLUE_FILE_MODEL_WORKER_H_
+#pragma once
+
+#include "base/callback.h"
+#include "chrome/browser/sync/engine/model_safe_worker.h"
+
+namespace base {
+class WaitableEvent;
+}
+

[akalin, 2011/09/14 18:11:11]

Add a TODO(sync) somewhere to combine ModelSafeWorker implementations that
differ only in which browser thread it's run on

[not at google - send to devlin, 2011/09/14 19:09:19]

The TODO would probably never get done, so I've done it.  Simpler.

+namespace browser_sync {
+
+// A ModelSafeWorker for file models that accepts requests from the syncapi
+// that need to be fulfilled on the FILE thread.
+class FileModelWorker : public browser_sync::ModelSafeWorker {
+ public:
+  explicit FileModelWorker() {}

[akalin, 2011/09/14 18:11:11]

no explicit on non-one-arg constructor

in fact, no explicit constructor needed

[not at google - send to devlin, 2011/09/14 19:09:19]

Constructor needed now, but un-explicited.

+

[akalin, 2011/09/14 18:11:11]

add virtual destructor (with non-inline body)

[not at google - send to devlin, 2011/09/14 19:09:19]

Done.

+  // ModelSafeWorker implementation. Called on syncapi SyncerThread.
+  virtual void DoWorkAndWaitUntilDone(Callback0::Type* work);
+  virtual ModelSafeGroup GetModelSafeGroup();
+
+ private:
+  void CallDoWorkAndSignalTask(Callback0::Type* work,
+                               base::WaitableEvent* done);
+
+  DISALLOW_COPY_AND_ASSIGN(FileModelWorker);

[akalin, 2011/09/14 18:11:11]

#include "base/basictypes.h" for this

[not at google - send to devlin, 2011/09/14 19:09:19]

Done.

+};
+
+}  // namespace browser_sync
+
+#endif  // CHROME_BROWSER_SYNC_GLUE_FILE_MODEL_WORKER_H_