Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 7891051: Fix for bug 81753, do not read past the end of unicode strings (Closed)

Created:
9 years, 3 months ago by Brad Chen
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix for bug 81753, do not read past the end of unicode strings BUG=81753 TEST=unit_tests

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -14 lines) Patch
M README.chromium View 1 1 chunk +4 lines, -0 lines 0 comments Download
A patches/rematch.patch View 1 1 chunk +60 lines, -0 lines 0 comments Download
M source/i18n/rematch.cpp View 1 3 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Brad Chen
Please review. Note I'm patching the source file directly, but maybe I ought to be ...
9 years, 3 months ago (2011-09-14 17:07:06 UTC) #1
jungshik at Google
Thank you for the fix. Can you make a patch and add it to patches ...
9 years, 3 months ago (2011-09-14 18:35:29 UTC) #2
Brad Chen
This is reasonable feedback, assuming it's the process you have been using. Do I understand ...
9 years, 3 months ago (2011-09-14 18:38:20 UTC) #3
Brad Chen
PTAL http://codereview.chromium.org/7891051/diff/1/source/i18n/rematch.cpp File source/i18n/rematch.cpp (right): http://codereview.chromium.org/7891051/diff/1/source/i18n/rematch.cpp#newcode5616 source/i18n/rematch.cpp:5616: } else { Done. Note this makes the ...
9 years, 3 months ago (2011-09-14 19:10:06 UTC) #4
jungshik at Google
LGTM ! Thank you. I'll talk to the upstream about taking your patch.
9 years, 3 months ago (2011-09-14 19:24:23 UTC) #5
jungshik at Google
On 2011/09/14 19:24:23, Jungshik Shin wrote: > LGTM ! Thank you. > > I'll talk ...
9 years, 3 months ago (2011-09-14 19:24:53 UTC) #6
Brad Chen
Thanks. I am going to way for some trybot runs and then use the commit ...
9 years, 3 months ago (2011-09-14 19:54:26 UTC) #7
commit-bot: I haz the power
Change committed as 101167
9 years, 3 months ago (2011-09-14 21:45:13 UTC) #8
jungshik at Google
9 years, 3 months ago (2011-09-14 22:44:16 UTC) #9
On 2011/09/14 19:54:26, Brad Chen wrote:
> Thanks. I am going to way for some trybot runs and then use the commit
> queue.

Actually, committing this CL is no-op until you roll the version of ICU in
src/DEPS file. 

So, you need a separate CL to roll the ICU revision to r101167 :-)



> 
> Brad
> 
> On Wed, Sep 14, 2011 at 12:24 PM,
<https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jshin@chromium.org> wrote:
> 
> > On 2011/09/14 19:24:23, Jungshik Shin wrote:
> >
> >> LGTM ! Thank you.
> >>
> >
> >  I'll talk to the upstream about taking your patch.
> >>
> >
> > Before landing, could you add a reference to the upstream bug in the CL
> > description? Thanks
> >
> >
> >
>
http://codereview.chromium.**org/7891051/%3Chttp://codereview.chromium.org/78...>
> >

Powered by Google App Engine
This is Rietveld 408576698