Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 7891045: Add "native" target to Makefile for the benefit of Linux distros (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow
Modified:
9 years, 3 months ago
Reviewers:
Yang, Paweł Hajdan Jr.
CC:
v8-dev
Visibility:
Public.

Description

Add "native" target to Makefile for the benefit of Linux distros TEST=make native; make native.check; make native.clean Committed: http://code.google.com/p/v8/source/detail?r=9292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -20 lines) Patch
M Makefile View 6 chunks +21 lines, -2 lines 0 comments Download
M build/standalone.gypi View 1 chunk +16 lines, -12 lines 0 comments Download
M tools/test-wrapper-gypbuild.py View 2 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Yang: PTAL. Paweł: Happy?
9 years, 3 months ago (2011-09-14 15:32:30 UTC) #1
Paweł Hajdan Jr.
Looks good, thank you (LGTM). I'm going to run make native first and then make ...
9 years, 3 months ago (2011-09-14 18:27:59 UTC) #2
Yang
9 years, 3 months ago (2011-09-15 07:52:47 UTC) #3
On 2011/09/14 18:27:59, Paweł Hajdan Jr. wrote:
> Looks good, thank you (LGTM).
> 
> I'm going to run make native first and then make native.check. Looks like it
> would work.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698