| 
        
       | 
      
        
  
  Add asserts to ensure that we:
1) Don't make a call to C without having a valid frame on the stack.
2) Don't generate a call to a stub while generating a stub, unless we can be
sure that the stub we are calling has already been generated (the stub
generation code is not reentrant wrt. GC).
Committed:  http://code.google.com/p/v8/source/detail?r=9297
   
  
  
    
      Total comments: 2
      
     
  
  
  
   
  
  
  
  
  
   
  
  
  
  
  
   
  
  
  
  
    
  
  
    
       | 
      Unified diffs | 
      Side-by-side diffs | 
      Delta from patch set | 
      Stats (+2971 lines, -2517 lines) | 
      Patch | 
     
    
      
          | 
        M     | 
        
          
            include/v8.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +5 lines, -5 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/builtins-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          11 chunks | 
          +528 lines, -509 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/code-stubs-arm.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +3 lines, -1 line | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/code-stubs-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          12 chunks | 
          +66 lines, -47 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/codegen-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -2 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/debug-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          1 chunk | 
          +39 lines, -37 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/deoptimizer-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +9 lines, -3 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/full-codegen-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +5 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/ic-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +19 lines, -17 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/lithium-codegen-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/macro-assembler-arm.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          6 chunks | 
          +9 lines, -14 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/macro-assembler-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          12 chunks | 
          +37 lines, -9 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/regexp-macro-assembler-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +12 lines, -3 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/arm/stub-cache-arm.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          6 chunks | 
          +52 lines, -45 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/builtins.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +1 line, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/code-stubs.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          5 chunks | 
          +21 lines, -4 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/code-stubs.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +3 lines, -2 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/deoptimizer.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +4 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/frames.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +4 lines, -1 line | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/builtins-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
          3
        
         | 
        
          15 chunks | 
          +348 lines, -331 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/code-stubs-ia32.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +3 lines, -1 line | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/code-stubs-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          8 chunks | 
          +47 lines, -37 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/codegen-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -2 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/debug-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          1 chunk | 
          +43 lines, -42 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/deoptimizer-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +9 lines, -3 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/full-codegen-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +5 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/ic-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +24 lines, -20 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/lithium-codegen-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/macro-assembler-ia32.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          5 chunks | 
          +9 lines, -13 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/macro-assembler-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          13 chunks | 
          +37 lines, -10 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/regexp-macro-assembler-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +12 lines, -4 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/ia32/stub-cache-ia32.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          4 chunks | 
          +47 lines, -42 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/macro-assembler.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +57 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/builtins-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          8 chunks | 
          +498 lines, -484 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/code-stubs-mips.h
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          2 chunks | 
          +3 lines, -1 line | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/code-stubs-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          11 chunks | 
          +62 lines, -45 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/codegen-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          1 chunk | 
          +6 lines, -2 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/debug-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
          3
        
         | 
        
          1 chunk | 
          +40 lines, -37 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/full-codegen-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          1 chunk | 
          +5 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/ic-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          2 chunks | 
          +19 lines, -17 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/macro-assembler-mips.h
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          5 chunks | 
          +8 lines, -13 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/macro-assembler-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
         | 
        
          13 chunks | 
          +37 lines, -9 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/regexp-macro-assembler-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
          3
        
         | 
        
          2 chunks | 
          +12 lines, -3 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/mips/stub-cache-mips.cc
          
         | 
        
          
            View
          
         | 
        
        
          1
        
          2
        
          3
        
         | 
        
          6 chunks | 
          +50 lines, -44 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/builtins-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          10 chunks | 
          +512 lines, -491 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/code-stubs-x64.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +3 lines, -1 line | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/code-stubs-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          6 chunks | 
          +29 lines, -21 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/codegen-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -2 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/debug-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          1 chunk | 
          +50 lines, -49 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/deoptimizer-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +9 lines, -3 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/full-codegen-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +5 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/ic-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +21 lines, -19 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/lithium-codegen-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/macro-assembler-x64.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          6 chunks | 
          +10 lines, -13 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/macro-assembler-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          13 chunks | 
          +37 lines, -13 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/regexp-macro-assembler-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +14 lines, -4 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M     | 
        
          
            src/x64/stub-cache-x64.cc
          
         | 
        
          
            View
          
         | 
        
        
          2
        
          3
        
         | 
        
          4 chunks | 
          +47 lines, -42 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
   
  
  
 
  
   
  
    
  
  
  
    
    Total messages: 3 (0 generated)
     
  
  
       |