Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 7891039: Resubmit - Rewrite color space conversions suite using YASM" (Closed)

Created:
9 years, 3 months ago by Alpha Left Google
Modified:
9 years, 3 months ago
Reviewers:
ajwong, dhollowa
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Resubmit - Rewrite color space conversions suite using YASM" I'll watch the official buildbot this time. TBR=ajwong, dhollowa BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1875 lines, -192 lines) Patch
M media/base/cpu_features.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/cpu_features_x86.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A media/base/simd/convert_rgb_to_yuv_x86.cc View 1 chunk +101 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb.h View 1 chunk +150 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb_c.cc View 1 chunk +155 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb_mmx.asm View 1 chunk +22 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb_mmx.inc View 1 chunk +119 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb_sse.asm View 1 chunk +23 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb_x86.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A media/base/simd/filter_yuv.h View 1 chunk +29 lines, -0 lines 0 comments Download
A media/base/simd/filter_yuv_c.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A media/base/simd/filter_yuv_mmx.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A media/base/simd/filter_yuv_sse2.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A media/base/simd/linear_scale_yuv_to_rgb_mmx.asm View 1 chunk +23 lines, -0 lines 0 comments Download
A media/base/simd/linear_scale_yuv_to_rgb_mmx.inc View 1 chunk +166 lines, -0 lines 0 comments Download
A media/base/simd/linear_scale_yuv_to_rgb_mmx_x64.asm View 1 chunk +142 lines, -0 lines 0 comments Download
A media/base/simd/linear_scale_yuv_to_rgb_sse.asm View 1 chunk +23 lines, -0 lines 0 comments Download
A media/base/simd/scale_yuv_to_rgb_mmx.asm View 1 chunk +23 lines, -0 lines 0 comments Download
A media/base/simd/scale_yuv_to_rgb_mmx.inc View 1 chunk +115 lines, -0 lines 0 comments Download
A media/base/simd/scale_yuv_to_rgb_sse.asm View 1 chunk +23 lines, -0 lines 0 comments Download
A media/base/simd/scale_yuv_to_rgb_sse2_x64.asm View 1 chunk +109 lines, -0 lines 0 comments Download
M media/base/simd/x86inc.asm View 2 chunks +8 lines, -0 lines 0 comments Download
M media/base/yuv_convert.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/yuv_convert.cc View 9 chunks +119 lines, -164 lines 0 comments Download
M media/base/yuv_convert_internal.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 3 chunks +240 lines, -12 lines 0 comments Download
M media/base/yuv_row_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/media.gyp View 4 chunks +49 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
9 years, 3 months ago (2011-09-14 11:11:35 UTC) #1
Alpha Left Google
9 years, 3 months ago (2011-09-14 12:41:06 UTC) #2
dhollowa
9 years, 3 months ago (2011-09-14 17:16:18 UTC) #3
Rubber stamp LGTM from sheriff.  Tree stayed green.

Powered by Google App Engine
This is Rietveld 408576698