Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 7891033: MIPS: port Implement function proxies (except for their use as constructors). (Closed)

Created:
9 years, 3 months ago by Paul Lind
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry, Yang, rossberg
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Implement function proxies (except for their use as constructors). port r9258 (c8709a9) Note on mips implementation: Arm reg r4 (call type) normally maps to mips reg t0. We had already used t0 as a temp in Generate_FunctionCall() and Generate_FunctionApply(), so I replaced that existing t0 usage with t3, and now use t0 only for call type. Original commit message: Introduce new %Apply native. Extend Execution::Call to optionally handle receiver rewriting (needed for %Apply). Fix Function.prototype.bind for functions that have .apply modified. BUG= TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated per review comment. #

Patch Set 3 : Rebased on bleeding_edge, resolved merge problem with r9297 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -40 lines) Patch
M src/mips/builtins-mips.cc View 1 2 10 chunks +83 lines, -38 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paul Lind
9 years, 3 months ago (2011-09-14 01:40:03 UTC) #1
Yang
Small nit. http://codereview.chromium.org/7891033/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): http://codereview.chromium.org/7891033/diff/1/src/mips/builtins-mips.cc#newcode1418 src/mips/builtins-mips.cc:1418: // Load the shared function info while ...
9 years, 3 months ago (2011-09-15 09:51:14 UTC) #2
Yang
On 2011/09/15 09:51:14, Yang wrote: > Small nit. > > http://codereview.chromium.org/7891033/diff/1/src/mips/builtins-mips.cc > File src/mips/builtins-mips.cc (right): ...
9 years, 3 months ago (2011-09-15 09:51:28 UTC) #3
Paul Lind
Updated per code review. http://codereview.chromium.org/7891033/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): http://codereview.chromium.org/7891033/diff/1/src/mips/builtins-mips.cc#newcode1418 src/mips/builtins-mips.cc:1418: // Load the shared function ...
9 years, 3 months ago (2011-09-15 15:12:11 UTC) #4
Yang
On 2011/09/15 15:12:11, Paul Lind wrote: > Updated per code review. > > http://codereview.chromium.org/7891033/diff/1/src/mips/builtins-mips.cc > ...
9 years, 3 months ago (2011-09-16 09:22:34 UTC) #5
Paul Lind
Hi Yang, Andreas - I resolved the merge problem on this one, please take another ...
9 years, 3 months ago (2011-09-16 23:48:54 UTC) #6
Erik Corry
9 years, 3 months ago (2011-09-18 15:12:08 UTC) #7
Landed as 9316

Powered by Google App Engine
This is Rietveld 408576698