Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: chrome/browser/chromeos/cros/network_library.cc

Issue 7891021: Use stub impl when libcros fails to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase with power library changes Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/mount_library.cc ('k') | chrome/browser/chromeos/cros/power_library.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library.cc
diff --git a/chrome/browser/chromeos/cros/network_library.cc b/chrome/browser/chromeos/cros/network_library.cc
index a9ab1833b324b97c14583b02e75f21f6b74abae3..eb7516fab417ff2b5a6727065a39b1664ce5cae6 100644
--- a/chrome/browser/chromeos/cros/network_library.cc
+++ b/chrome/browser/chromeos/cros/network_library.cc
@@ -4940,18 +4940,11 @@ void NetworkLibraryImplStub::SetIPConfig(const NetworkIPConfig& ipconfig) {
// static
NetworkLibrary* NetworkLibrary::GetImpl(bool stub) {
NetworkLibrary* impl;
- // If CrosLibrary failed to load, use the stub implementation, since the
- // cros implementation would crash on any libcros call.
- if (!stub && !CrosLibrary::Get()->libcros_loaded()) {
- LOG(WARNING) << "NetworkLibrary: falling back to stub impl.";
- stub = true;
- }
if (stub)
impl = new NetworkLibraryImplStub();
else
impl = new NetworkLibraryImplCros();
impl->Init();
-
return impl;
}
« no previous file with comments | « chrome/browser/chromeos/cros/mount_library.cc ('k') | chrome/browser/chromeos/cros/power_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698