Use stub impl when libcros fails to load

chrome/browser/chromeos/cros/brightness_library.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros/brightness_library.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 10 matching lines @@
 
   virtual ~BrightnessLibraryImpl() {
     if (brightness_connection_) {
       chromeos::DisconnectBrightness(brightness_connection_);
       brightness_connection_ = NULL;
     }
   }
 
   // Begin BrightnessLibrary implementation.
   virtual void Init() OVERRIDE {
-    if (CrosLibrary::Get()->EnsureLoaded()) {
-      CHECK(!brightness_connection_) << "Already intialized";
-      brightness_connection_ =
-          chromeos::MonitorBrightnessV2(&BrightnessChangedHandler, this);
-    }
+    DCHECK(CrosLibrary::Get()->libcros_loaded());
+    CHECK(!brightness_connection_) << "Already intialized";
+    brightness_connection_ =
+        chromeos::MonitorBrightnessV2(&BrightnessChangedHandler, this);
   }
 
   virtual void AddObserver(Observer* observer) OVERRIDE {
     observers_.AddObserver(observer);
   }
 
   virtual void RemoveObserver(Observer* observer) OVERRIDE {
     observers_.RemoveObserver(observer);
   }
 
   virtual void DecreaseScreenBrightness(bool allow_off) OVERRIDE {
-    if (chromeos::DecreaseScreenBrightness)
-      chromeos::DecreaseScreenBrightness(allow_off);
+    chromeos::DecreaseScreenBrightness(allow_off);
   }
 
   virtual void IncreaseScreenBrightness() OVERRIDE {
-    if (chromeos::IncreaseScreenBrightness)
       chromeos::IncreaseScreenBrightness();

[satorux1, 2011/09/16 20:05:55]

Indentation is off?

[stevenjb, 2011/09/16 21:44:24]

Done.

   }
   // End BrightnessLibrary implementation.
 
  private:
   static void BrightnessChangedHandler(void* object,
                                        int brightness_level,
                                        bool user_initiated) {
     BrightnessLibraryImpl* self = static_cast<BrightnessLibraryImpl*>(object);
     self->OnBrightnessChanged(brightness_level, user_initiated);
   }
@@ skipping 40 matching lines @@
   else
     impl = new BrightnessLibraryImpl();
   impl->Init();
   return impl;
 }
 
 }  // namespace chromeos
 
 // Needed for NewRunnableMethod() call above.
 DISABLE_RUNNABLE_METHOD_REFCOUNT(chromeos::BrightnessLibraryImpl);