Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 7891018: Fixes possible deadlock between history and bookmarks. The deadlock (Closed)

Created:
9 years, 3 months ago by sky
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes possible deadlock between history and bookmarks. The deadlock would occur if you attempted to exit the browser, bookmarks hadn't finished loading yet and HistoryBackend was waiting for bookmarks to finish loading. In such a scenario bookmarks will never finish loading because the UI thread is blocked waiting for history to finish shutdown, but history can't finish because it's waiting for bookmarks. I'm fixing it by signaling that bookmarks have finished loading, even though that isn't entirely accurate in this case. It's possible that could lead to nuking some favicons for bookmarks, but this scenario is so rare that (IMO) it's not worth trying to handle specially. BUG=96100 TEST=none R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/bookmarks/bookmark_model.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
9 years, 3 months ago (2011-09-13 20:35:04 UTC) #1
brettw
LGTM
9 years, 3 months ago (2011-09-13 21:49:14 UTC) #2
sky
Miranda, could you review the change to ProfileImpl. Thanks, -Scott
9 years, 3 months ago (2011-09-14 14:44:05 UTC) #3
Miranda Callahan
9 years, 3 months ago (2011-09-14 14:48:27 UTC) #4
On 2011/09/14 14:44:05, sky wrote:
> Miranda, could you review the change to ProfileImpl.
> 
> Thanks,
> 
>   -Scott

ProfileImpl LGTM.

Powered by Google App Engine
This is Rietveld 408576698