Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 7891010: Implement shrinking of paged spaces during sweeping. (Closed)

Created:
9 years, 3 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Implement shrinking of paged spaces during sweeping. For each paged space we release all but one of the unused pages after marking (when we know the number of live bytes) but before actually sweeping it. This is not yet done for lazy swept pages. R=erik.corry@gmail.com BUG=v8:1614 Committed: http://code.google.com/p/v8/source/detail?r=9481

Patch Set 1 #

Patch Set 2 : Added tracing output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -117 lines) Patch
M src/heap.h View 1 3 chunks +0 lines, -22 lines 0 comments Download
M src/heap.cc View 1 4 chunks +2 lines, -4 lines 0 comments Download
M src/mark-compact.cc View 1 6 chunks +18 lines, -64 lines 0 comments Download
M src/spaces.h View 1 3 chunks +14 lines, -4 lines 0 comments Download
M src/spaces.cc View 1 4 chunks +26 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
PTAL.
9 years, 3 months ago (2011-09-13 17:12:13 UTC) #1
Erik Corry
LGTM I like changes that delete code :-)
9 years, 3 months ago (2011-09-14 08:06:13 UTC) #2
Michael Starzinger
9 years, 3 months ago (2011-09-16 11:23:20 UTC) #3
Just for the record: This is blocked by issue v8:1614 because it depends on
page->LiveBytes() being (semi-)accurate. So I am holding off landing it until
that is resolved.

Powered by Google App Engine
This is Rietveld 408576698