Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/d8.h

Issue 7891005: Fixing parallel execution in d8 (with -p) and some memory leaks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/d8.cc » ('j') | src/d8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index 052b4c023d9ec369d886da1c1ae65b592e622bac..9cc482ad7f6c43df09cf2b564385f3b6ec2b481e 100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -180,6 +180,7 @@ class ShellOptions {
#ifndef V8_SHARED
use_preemption(true),
preemption_interval(10),
+ num_parallel_files(0),
parallel_files(NULL),
#endif // V8_SHARED
script_executed(false),
@@ -191,12 +192,18 @@ class ShellOptions {
num_isolates(1),
isolate_sources(NULL) { }
- ~ShellOptions();
+ ~ShellOptions() {
+#ifndef V8_SHARED
+ if (parallel_files != NULL) delete[] parallel_files;
fschneider 2011/09/13 12:08:57 Same here.
+#endif // V8_SHARED
+ if (isolate_sources != NULL) delete[] isolate_sources;
fschneider 2011/09/13 12:08:57 No need to check for NULL for delete.
+ }
#ifndef V8_SHARED
bool use_preemption;
int preemption_interval;
- i::List< i::Vector<const char> >* parallel_files;
+ int num_parallel_files;
+ char** parallel_files;
#endif // V8_SHARED
bool script_executed;
bool last_run;
@@ -225,6 +232,7 @@ class Shell : public i::AllStatic {
static Persistent<Context> CreateEvaluationContext();
static int RunMain(int argc, char* argv[]);
static int Main(int argc, char* argv[]);
+ static void Exit(int exit_code);
#ifndef V8_SHARED
static Handle<Array> GetCompletions(Handle<String> text,
« no previous file with comments | « no previous file | src/d8.cc » ('j') | src/d8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698