Added CopyRegKeyWorkItem in support of IE low rights policy fixes.

chrome/installer/util/copy_reg_key_work_item.h

Index: chrome/installer/util/copy_reg_key_work_item.h
diff --git a/chrome/installer/util/copy_reg_key_work_item.h b/chrome/installer/util/copy_reg_key_work_item.h
new file mode 100644
index 0000000000000000000000000000000000000000..4086598ee3fb89435f188e554c54d8fa55363075
--- /dev/null
+++ b/chrome/installer/util/copy_reg_key_work_item.h
@@ -0,0 +1,50 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_UTIL_COPY_REG_KEY_WORK_ITEM_H_
+#define CHROME_INSTALLER_UTIL_COPY_REG_KEY_WORK_ITEM_H_
+#pragma once
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/installer/util/work_item.h"
+
+class RegistryKeyBackup;
+
+// A WorkItem subclass that recursively copies a registry key.  Be aware
+// that in the event of rollback the key's values and subkeys are restored but

[erikwright (departed), 2011/09/15 18:38:57]

In the case of a rollback, why would the new key and subkeys still exist?
Presumably because this task can overwrite existing data? Might be worth
explicitly documenting its behaviour in this case.

[grt (UTC plus 2), 2011/09/16 17:45:45]

Done.

+// the key and its subkeys take on their default security descriptors.
+class CopyRegKeyWorkItem : public WorkItem {
+ public:
+  ~CopyRegKeyWorkItem();

[erikwright (departed), 2011/09/15 18:38:57]

I think this destructor should explicitly be marked as virtual.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Inheri...

[grt (UTC plus 2), 2011/09/16 17:45:45]

Done.

+  virtual bool Do() OVERRIDE;
+  virtual void Rollback() OVERRIDE;
+
+ private:
+  friend class WorkItem;
+
+  CopyRegKeyWorkItem(HKEY predefined_key,
+                     const std::wstring& source_key_path,
+                     const std::wstring& dest_key_path);
+
+  // Root key in which we operate. The root key must be one of the predefined
+  // keys on Windows.
+  HKEY predefined_root_;
+
+  // Path of the key to be copied.
+  std::wstring source_key_path_;
+
+  // Path of the destination key.
+  std::wstring dest_key_path_;
+
+  // Backup of the destination key.
+  scoped_ptr<RegistryKeyBackup> backup_;
+
+  DISALLOW_COPY_AND_ASSIGN(CopyRegKeyWorkItem);
+};
+
+#endif  // CHROME_INSTALLER_UTIL_COPY_REG_KEY_WORK_ITEM_H_