Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7890054: Adds code for a new Aura shell. (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)
Modified:
9 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

Adds to the shell: - a desktop background - a stub launcher - clicking on the background opens new windows BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -33 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/desktop.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M ui/aura/window_delegate.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M ui/aura_shell/aura_shell_main.cc View 1 2 3 2 chunks +17 lines, -12 lines 0 comments Download
M ui/aura_shell/desktop_background_view.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_shell/desktop_background_view.cc View 1 2 3 2 chunks +22 lines, -3 lines 0 comments Download
M ui/aura_shell/desktop_layout_manager.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura_shell/desktop_layout_manager.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
A ui/aura_shell/launcher/launcher_button.h View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A ui/aura_shell/launcher/launcher_button.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A + ui/aura_shell/launcher/launcher_view.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A + ui/aura_shell/launcher/launcher_view.cc View 1 2 3 1 chunk +40 lines, -1 line 0 comments Download
D ui/aura_shell/launcher_view.h View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
D ui/aura_shell/launcher_view.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
A ui/aura_shell/sample_window.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A ui/aura_shell/sample_window.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A ui/aura_shell/shell_factory.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A ui/resources/aura/applist.png View 1 2 Binary file 0 comments Download
A ui/resources/aura/browser-instance.png View 1 2 Binary file 0 comments Download
A ui/resources/aura/chromeicon.png View 1 2 Binary file 0 comments Download
A ui/resources/aura/damask.png View 1 2 Binary file 0 comments Download
A ui/resources/aura/statusbar.png View 1 2 Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 3 months ago (2011-09-15 20:37:35 UTC) #1
sky
9 years, 3 months ago (2011-09-15 20:39:35 UTC) #2 
LGTM

http://codereview.chromium.org/7890054/diff/6001/ui/aura_shell/desktop_backgr...
File ui/aura_shell/desktop_background_view.cc (right):

http://codereview.chromium.org/7890054/diff/6001/ui/aura_shell/desktop_backgr...
ui/aura_shell/desktop_background_view.cc:28: canvas->TileImageInt(wallpaper_, 0,
0, width(), height());
Comment this out too.

Powered by Google App Engine
This is Rietveld 408576698