mac: Clobber pch files after clang updates.

mac: Clobber pch files after clang updates.

BUG=96522
TEST=Mark stops seeing pch errors after clang updates

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101237

[Nico, 2011-09-14 21:31:34]

Once this (and the other 2 CLs) are in, I'd like to commit the "clang on by
default" CL. Ok?

http://codereview.chromium.org/7890052/diff/3/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/7890052/diff/3/tools/clang/scripts/update.sh#n...
tools/clang/scripts/update.sh:65: if [[ "$(uname -s)" = "Darwin" ]]; then
I'll switch this to ${OS} once that other CL is in and I have rebased.

[Mark Mentovai, 2011-09-15 02:53:46]

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:88: if [[ -d "${MAKE_DIR}/${CONFIG}" ]]; then
Want to include /obj.target here too?

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:90: find "${MAKE_DIR}/${CONFIG}/obj.target" -name
'*.gch' | xargs rm
find "${MAKE_DIR}/${CONFIG}/obj.target" -name '*.gch' -exec rm {} +

A little safer and faster.

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:93: if [[ -d "${XCODEBUILD_DIR}/${CONFIG}" ]];
then
Want to include /SharedPrecompiledHeaders here too?

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:94: echo "Clobbering ${CONFIG} PCH files for xcode
build"
Nit: capital X in Xcode.

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:95: rm -rf
"${XCODEBUILD_DIR}/${CONFIG}"/SharedPrecompiledHeaders/*
Drop the /*. It’s OK to just remove all of SharedPrecompiledHeaders and let
Xcode recreate it.

Put the "quotes" around the entire string.

[Nico, 2011-09-15 03:00:07]

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:88: if [[ -d "${MAKE_DIR}/${CONFIG}" ]]; then
On 2011/09/15 02:53:46, Mark Mentovai wrote:
> Want to include /obj.target here too?

Done.

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:90: find "${MAKE_DIR}/${CONFIG}/obj.target" -name
'*.gch' | xargs rm
On 2011/09/15 02:53:46, Mark Mentovai wrote:
> find "${MAKE_DIR}/${CONFIG}/obj.target" -name '*.gch' -exec rm {} +
> 
> A little safer and faster.

Done. (DIdn't know about '+' up until now, thanks!)

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:93: if [[ -d "${XCODEBUILD_DIR}/${CONFIG}" ]];
then
On 2011/09/15 02:53:46, Mark Mentovai wrote:
> Want to include /SharedPrecompiledHeaders here too?

Done.

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:94: echo "Clobbering ${CONFIG} PCH files for xcode
build"
On 2011/09/15 02:53:46, Mark Mentovai wrote:
> Nit: capital X in Xcode.

Done.

http://codereview.chromium.org/7890052/diff/5001/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:95: rm -rf
"${XCODEBUILD_DIR}/${CONFIG}"/SharedPrecompiledHeaders/*
On 2011/09/15 02:53:46, Mark Mentovai wrote:
> Drop the /*. It’s OK to just remove all of SharedPrecompiledHeaders and let
> Xcode recreate it.

Done.

> Put the "quotes" around the entire string.

With the *, the quotes prevented * expansion.

[Mark Mentovai, 2011-09-15 03:06:50]

LGTM

http://codereview.chromium.org/7890052/diff/4002/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/7890052/diff/4002/tools/clang/scripts/update.s...
tools/clang/scripts/update.sh:95: rm -rf
"${XCODEBUILD_DIR}/${CONFIG}/SharedPrecompiledHeaders"
When this had a *, the " should have enclosed everything but the *.